[coreboot-gerrit] Patch set updated for coreboot: 0477ff2 util/cbfstool/cbfs-mkstage.c: Fix build issue in GCC 4.6.3

Francis Rowe (info@gluglug.org.uk) gerrit at coreboot.org
Fri Nov 21 04:03:30 CET 2014


Francis Rowe (info at gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7545

-gerrit

commit 0477ff2b3479ad4942d90adbd6ef7962071ef026
Author: Francis Rowe <info at gluglug.org.uk>
Date:   Fri Nov 21 02:38:48 2014 +0000

    util/cbfstool/cbfs-mkstage.c: Fix build issue in GCC 4.6.3
    
    Tested on a 32-bit distro (kernel built for i686), Trisquel 6 (based on Ubuntu 12.04 LTS).
    
    Error was:
    cbfs-mkstage.c: In function ‘is_phdr_ignored’:
    cbfs-mkstage.c:45:84: error: cast to pointer from integer of
    different size [-Werror=int-to-pointer-cast]
    
    When applying this patch, cbfstool builds and works perfectly.
    
    Change-Id: If9e3eea9ab2c05027f660d0057a635abf981b901
    Signed-off-by: Francis Rowe <info at gluglug.org.uk>
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/cbfstool/cbfs-mkstage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfs-mkstage.c b/util/cbfstool/cbfs-mkstage.c
index 8459334..a423481 100644
--- a/util/cbfstool/cbfs-mkstage.c
+++ b/util/cbfstool/cbfs-mkstage.c
@@ -42,7 +42,7 @@ static int is_phdr_ignored(Elf64_Phdr *phdr, Elf64_Shdr *shdr)
 
 	/* Return true only if section occupies whole of segment. */
 	if ((sh_start == ph_start) && (sh_end == ph_end)) {
-		DEBUG("Ignoring program segment at %p\n", (void *)ph_start);
+		DEBUG("Ignoring program segment at %p\n", (void *)(intptr_t)ph_start);
 		return 1;
 	}
 



More information about the coreboot-gerrit mailing list