[coreboot-gerrit] Patch set updated for coreboot: 486fed3 fsp_baytrail: upd CPU stepping display for Baytrail D0 step

Herve ELTER (rvnvv2@gmail.com) gerrit at coreboot.org
Wed Nov 19 18:01:04 CET 2014


Herve ELTER (rvnvv2 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7525

-gerrit

commit 486fed3c73ab4eb7dae1bc99273cdefb9eb0ac0e
Author: Herve Elter <rvnvv74 at gmail.com>
Date:   Wed Nov 19 17:28:03 2014 +0100

    fsp_baytrail: upd CPU stepping display for Baytrail D0 step
    
    Change-Id: Id7800bde6b9a487a5a44544e053e9ce61ccd6878
    Signed-off-by: Herve Elter <rvnvv74 at gmail.com>
---
 src/soc/intel/fsp_baytrail/baytrail/lpc.h | 2 ++
 src/soc/intel/fsp_baytrail/ramstage.c     | 8 ++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/fsp_baytrail/baytrail/lpc.h b/src/soc/intel/fsp_baytrail/baytrail/lpc.h
index 9dd0439..f40b4c0 100644
--- a/src/soc/intel/fsp_baytrail/baytrail/lpc.h
+++ b/src/soc/intel/fsp_baytrail/baytrail/lpc.h
@@ -90,6 +90,7 @@
 #define RID_A_STEPPING_START 1
 #define RID_B_STEPPING_START 5
 #define RID_C_STEPPING_START 0xe
+#define RID_D_STEPPING_START 0x11
 enum baytrail_stepping {
 	STEP_A0,
 	STEP_A1,
@@ -98,6 +99,7 @@ enum baytrail_stepping {
 	STEP_B2,
 	STEP_B3,
 	STEP_C0,
+	STEP_D0,
 };
 
 /* Registers behind the RCBA_BASE_ADDRESS bar. */
diff --git a/src/soc/intel/fsp_baytrail/ramstage.c b/src/soc/intel/fsp_baytrail/ramstage.c
index 814b16e..7776c1b 100644
--- a/src/soc/intel/fsp_baytrail/ramstage.c
+++ b/src/soc/intel/fsp_baytrail/ramstage.c
@@ -71,7 +71,7 @@ static inline void fill_in_msr(msr_t *msr, int idx)
 }
 
 static const char *stepping_str[] = {
-	"A0", "A1", "B0", "B1", "B2", "B3"
+	"A0", "A1", "B0", "B1", "B2", "B3" , "C0" , "D0"
 };
 
 static void fill_in_pattrs(void)
@@ -83,7 +83,11 @@ static void fill_in_pattrs(void)
 	attrs->cpuid = cpuid_eax(1);
 	dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC));
 	attrs->revid = pci_read_config8(dev, REVID);
-	/* The revision to stepping IDs have two values per metal stepping. */
+	/* The revision to stepping IDs have 3 values per metal stepping. */
+	if (attrs->revid >= RID_D_STEPPING_START) {
+		attrs->stepping = (attrs->revid - RID_D_STEPPING_START) / 2;
+		attrs->stepping += STEP_D0;
+	} else
 	if (attrs->revid >= RID_B_STEPPING_START) {
 		attrs->stepping = (attrs->revid - RID_B_STEPPING_START) / 2;
 		attrs->stepping += STEP_B0;



More information about the coreboot-gerrit mailing list