[coreboot-gerrit] New patch to review for coreboot: 307b755 tegra124: remove spurious error message

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Nov 17 09:31:47 CET 2014


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7502

-gerrit

commit 307b755e531e096aba1b63ca5f9e8483d881a704
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Nov 17 09:30:59 2014 +0100

    tegra124: remove spurious error message
    
    Configuring a link bandwidth configuration and then
    complaining that it's invalid seems unreasonable.
    
    Change-Id: I6423da6700d4f266222458758c885a4ea47e0df9
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 src/soc/nvidia/tegra124/sor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c
index 3a27648..6151ae6 100644
--- a/src/soc/nvidia/tegra124/sor.c
+++ b/src/soc/nvidia/tegra124/sor.c
@@ -765,6 +765,7 @@ void tegra_dc_sor_power_down_unused_lanes(struct tegra_dc_sor_data *sor)
 	case SOR_LINK_SPEED_G5_4:
 		drive_current = 0x19191919;
 		pre_emphasis = 0x09090909;
+		break;
 	default:
 		printk(BIOS_ERR, "Invalid sor link bandwidth: %d\n",
 			sor->link_cfg->link_bw);



More information about the coreboot-gerrit mailing list