[coreboot-gerrit] New patch to review for coreboot: 78dcb93 util/abuild/abuild: Avoid race between script and resulting xml

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7491

-gerrit

commit 78dcb93c672e26356a0cf51599f6eadb7c4c2c70
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon Nov 17 14:43:25 2014 +1100

    util/abuild/abuild: Avoid race between script and resulting xml
    
    abuild results in a XML file that can be as large as 4MB, depending
    on conditions of the day a race can occur in which we exit before
    abuild.xml exists on disk. The result is abuild.xml files with only
    the header part:
    
      <?xml version="1.0" encoding="utf-8"?>
        <testsuite>
    
    parsing this results in malformed XML file giving rise to exceptions
    thrown in various buildbots.
    
    Change-Id: Id0bb53ffe4d8652354548c89a0d44027410ddef1
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 util/abuild/abuild | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/util/abuild/abuild b/util/abuild/abuild
index ac516f7..1d88a86 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -624,4 +624,8 @@ else
 fi
 junit '</testsuite>'
 
+# sync to avoid race:
+# the resulting abuild.xml can be as large as 4MB,
+# we should not exit until it exists for analysis!
+sync ; sync ; sync
 exit $failed