[coreboot-gerrit] New patch to review for coreboot: 822f195 fsp_baytrail: update for UPD_DEFAULT_CHECK macro
Martin Roth (gaumless@gmail.com)
gerrit at coreboot.org
Mon Nov 17 04:36:28 CET 2014
Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7489
-gerrit
commit 822f19536845390dd55cb6930d9e56d1c508561d
Author: Martin Roth <martin.roth at se-eng.com>
Date: Sun Nov 16 20:07:16 2014 -0700
fsp_baytrail: update for UPD_DEFAULT_CHECK macro
- Update chipset_fsp_util.c to use the UPD_SPD_CHECK macro. This
makes the code more standardized and easier to read.
Change-Id: I9944e1a4df82e64a205598e98ed0f3b840af1019
Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
index e293973..7091c71 100644
--- a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
+++ b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
@@ -82,17 +82,8 @@ static void ConfigureDefaultUpdData(UPD_DATA_REGION *UpdData)
UpdData->AzaliaConfigPtr = (UINT32)&mAzaliaConfig;
/* Set SPD addresses */
- if (config->PcdMrcInitSPDAddr1 == SPD_ADDR_DISABLED)
- UpdData->PcdMrcInitSPDAddr1 = 0x00;
- else if (config->PcdMrcInitSPDAddr1 != SPD_ADDR_DEFAULT)
- UpdData->PcdMrcInitSPDAddr1 = config->PcdMrcInitSPDAddr1;
- printk(BIOS_DEBUG, "SPD Addr1:\t\t0x%02x\n", UpdData->PcdMrcInitSPDAddr1);
-
- if (config->PcdMrcInitSPDAddr2 == SPD_ADDR_DISABLED)
- UpdData->PcdMrcInitSPDAddr2 = 0x00;
- else if (config->PcdMrcInitSPDAddr2 != SPD_ADDR_DEFAULT)
- UpdData->PcdMrcInitSPDAddr2 = config->PcdMrcInitSPDAddr2;
- printk(BIOS_DEBUG, "SPD Addr2:\t\t0x%02x\n", UpdData->PcdMrcInitSPDAddr2);
+ UPD_SPD_CHECK(PcdMrcInitSPDAddr1);
+ UPD_SPD_CHECK(PcdMrcInitSPDAddr2);
UPD_DEFAULT_CHECK(PcdSataMode);
UPD_DEFAULT_CHECK(PcdLpssSioEnablePciMode);
More information about the coreboot-gerrit
mailing list