[coreboot-gerrit] New patch to review for coreboot: 7ffe571 i945: Fix splitting of dimm number into channel and socket.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Nov 16 21:07:57 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7483

-gerrit

commit 7ffe5715c1bfa5b6e990f5acadc71ea25a754c09
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Nov 16 21:05:59 2014 +0100

    i945: Fix splitting of dimm number into channel and socket.
    
    Change-Id: Ia6a65535f080beabb88aa12e11513a3b45aa3a9e
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/northbridge/intel/i945/raminit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index e823bab..6d6444a 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -379,14 +379,14 @@ static void sdram_get_dram_configuration(struct sys_info *sysinfo)
 		sysinfo->dimm[i] = SYSINFO_DIMM_NOT_POPULATED;
 
 		/* Dual Channel not supported, but Channel 1? Bail out */
-		if (!sdram_capabilities_dual_channel() && (i >> 1))
+		if (!sdram_capabilities_dual_channel() && (i >> 2))
 			continue;
 
 		/* Two DIMMs per channel not supported, but odd DIMM number? */
 		if (!sdram_capabilities_two_dimms_per_channel() && (i& 1))
 			continue;
 
-		printk(BIOS_DEBUG, "DDR II Channel %d Socket %d: ", (i >> 1), (i & 1));
+		printk(BIOS_DEBUG, "DDR II Channel %d Socket %d: ", (i >> 2), (i & 1));
 
 		if (spd_read_byte(device, SPD_MEMORY_TYPE) != SPD_MEMORY_TYPE_SDRAM_DDR2) {
 			printk(BIOS_DEBUG, "N/A\n");



More information about the coreboot-gerrit mailing list