[coreboot-gerrit] New patch to review for coreboot: fa5acb8 arm/tables: Kill weak get_cbmem_table.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Nov 10 02:57:48 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7391

-gerrit

commit fa5acb822f576a6508261951ab07e36356ffd463
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Mon Nov 10 02:54:25 2014 +0100

    arm/tables: Kill weak get_cbmem_table.
    
    A weak function which throws a warning actually delays until the error
    is discovered. Link error is better than runtime warning.
    
    Change-Id: Id320a5a0a16d966300d366193f8b963e8bd923a0
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/arm/tables.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/arch/arm/tables.c b/src/arch/arm/tables.c
index 20c5a9f..a2b7b9b 100644
--- a/src/arch/arm/tables.c
+++ b/src/arch/arm/tables.c
@@ -29,15 +29,6 @@
 
 #define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
 
-#if !CONFIG_DYNAMIC_CBMEM
-void __attribute__((weak)) get_cbmem_table(uint64_t *base, uint64_t *size)
-{
-	printk(BIOS_WARNING, "WARNING: you need to define get_cbmem_table for your board\n");
-	*base = 0;
-	*size = 0;
-}
-#endif
-
 void cbmem_arch_init(void)
 {
 }



More information about the coreboot-gerrit mailing list