[coreboot-gerrit] Patch set updated for coreboot: d09e4ac AMD Hudson boards: Hide HUDSON_LEGACY_FREE prompts.

Sun Nov 9 19:45:55 CET 2014

Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7358

-gerrit

commit d09e4ac9eed24bb2408e9bfef258b2be1af8b36f
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Nov 8 17:00:53 2014 +0100

    AMD Hudson boards: Hide HUDSON_LEGACY_FREE prompts.
    
    The legacy free property depends on the board design and shouldn't be
    user-selectable. Any legacy keyboard, serial or other controller enabled
    on FCH or SuperIO invalidates the legacy free setting.
    
    In particular, if a serial port is present and used for debugging, setting
    HUDSON_LEGACY_FREE will cause AGESA to disable FCH/LPC I/O decode of the
    serial port and prevent many early boot messages from being logged to the
    serial port.
    
    Change-Id: Ibc9297d75917a2dd4e056e554b10c0e86877d3ed
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
 src/mainboard/amd/olivehill/Kconfig         | 5 +----
 src/mainboard/amd/olivehillplus/Kconfig     | 5 +----
 src/mainboard/amd/parmer/Kconfig            | 5 +----
 src/mainboard/amd/thatcher/Kconfig          | 5 +----
 src/mainboard/asrock/imb-a180/Kconfig       | 4 ----
 src/mainboard/asus/f2a85-m/Kconfig          | 4 ----
 src/mainboard/hp/pavilion_m6_1035dx/Kconfig | 5 +----
 src/southbridge/amd/agesa/hudson/Kconfig    | 3 ++-
 8 files changed, 7 insertions(+), 29 deletions(-)

diff --git a/src/mainboard/amd/olivehill/Kconfig b/src/mainboard/amd/olivehill/Kconfig
index a089d21..f7c6916 100644
--- a/src/mainboard/amd/olivehill/Kconfig
+++ b/src/mainboard/amd/olivehill/Kconfig
@@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -76,8 +77,4 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_OLIVEHILL
diff --git a/src/mainboard/amd/olivehillplus/Kconfig b/src/mainboard/amd/olivehillplus/Kconfig
index a61859f..eae51a4 100644
--- a/src/mainboard/amd/olivehillplus/Kconfig
+++ b/src/mainboard/amd/olivehillplus/Kconfig
@@ -31,6 +31,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_8192
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -76,8 +77,4 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_OLIVEHILLPLUS
diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig
index 735321e..03496bd 100644
--- a/src/mainboard/amd/parmer/Kconfig
+++ b/src/mainboard/amd/parmer/Kconfig
@@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
 	select UDELAY_LAPIC
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -77,8 +78,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9900"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_PARMER
diff --git a/src/mainboard/amd/thatcher/Kconfig b/src/mainboard/amd/thatcher/Kconfig
index aacd1e3..8343fbd 100644
--- a/src/mainboard/amd/thatcher/Kconfig
+++ b/src/mainboard/amd/thatcher/Kconfig
@@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SUPERIO_SMSC_LPC47N217
 	select BOARD_ROMSIZE_KB_4096
 	select GFXUMA
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -77,8 +78,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9917"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_AMD_THATCHER
diff --git a/src/mainboard/asrock/imb-a180/Kconfig b/src/mainboard/asrock/imb-a180/Kconfig
index aa075c8..18bc5f6 100644
--- a/src/mainboard/asrock/imb-a180/Kconfig
+++ b/src/mainboard/asrock/imb-a180/Kconfig
@@ -77,10 +77,6 @@ config ONBOARD_VGA_IS_PRIMARY
 	bool
 	default y
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 # bit 1,0 - pin 0
 # bit 3,2 - pin 1
 # bit 5,4 - pin 2
diff --git a/src/mainboard/asus/f2a85-m/Kconfig b/src/mainboard/asus/f2a85-m/Kconfig
index 6dea246..b0f58f7 100644
--- a/src/mainboard/asus/f2a85-m/Kconfig
+++ b/src/mainboard/asus/f2a85-m/Kconfig
@@ -102,8 +102,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9993"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_ASUS_F2A85_M
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
index d82bfb5..4e2b121 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
+++ b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig
@@ -36,6 +36,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select GFXUMA
 	select UDELAY_LAPIC
 	select USBDEBUG_IN_ROMSTAGE
+	select HUDSON_LEGACY_FREE
 
 config MAINBOARD_DIR
 	string
@@ -81,8 +82,4 @@ config VGA_BIOS_ID
 	string
 	default "1002,9900"
 
-config HUDSON_LEGACY_FREE
-	bool
-	default y
-
 endif # BOARD_HP_PAVILION_M6_1035DX
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index a2a43a4..73539c9 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -241,7 +241,8 @@ endif # HUDSON_SATA_RAID
 config HUDSON_LEGACY_FREE
 	bool "System is legacy free"
 	help
-	  Select y if there is no keyboard controller in the system.
+	  Select y if there is no keyboard, serial or other legacy controllers
+	  enabled in the system, on both the FCH and any LPC SuperIO.
 	  This sets variables in AGESA and ACPI.
 
 config ACPI_ENABLE_THERMAL_ZONE

