[coreboot-gerrit] New patch to review for coreboot: e96b7ac get_top_of_ram: Don't define weak function unles BROKEN_CAR_MIGRATE is set.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Sun Nov 9 16:15:14 CET 2014
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7374
-gerrit
commit e96b7ac71b90ae6f6478c836900520df2abe09bf
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Sun Nov 9 13:41:35 2014 +0100
get_top_of_ram: Don't define weak function unles BROKEN_CAR_MIGRATE is set.
Compile-time error is better than runtime warning.
Change-Id: I8e8c06ada1772403a1cf632fbed192f6a9f367d0
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/arch/x86/boot/cbmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/arch/x86/boot/cbmem.c b/src/arch/x86/boot/cbmem.c
index 8b2b6da..1a1ffbf 100644
--- a/src/arch/x86/boot/cbmem.c
+++ b/src/arch/x86/boot/cbmem.c
@@ -51,8 +51,8 @@ void set_top_of_ram(uint64_t ramtop)
}
#endif /* !__PRE_RAM__ */
-#if CONFIG_BROKEN_CAR_MIGRATE || !defined(__PRE_RAM__)
-unsigned long __attribute__((weak)) get_top_of_ram(void)
+#if CONFIG_BROKEN_CAR_MIGRATE
+unsigned long get_top_of_ram(void)
{
printk(BIOS_WARNING, "WARNING: you need to define get_top_of_ram() for your chipset\n");
return 0;
More information about the coreboot-gerrit
mailing list