[coreboot-gerrit] Patch merged into coreboot/master: 25a282d arm: Thumb ALL the things!

gerrit at coreboot.org gerrit at coreboot.org
Sun Nov 9 01:37:16 CET 2014


the following patch was just integrated into master:
commit 25a282dabc5fb656a1402c26920974d129ef7917
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Jan 13 13:24:30 2014 -0800

    arm: Thumb ALL the things!
    
    This patch switches every last part of Coreboot on ARM over to Thumb
    mode: libpayload, the internal libgcc, and assorted assembly files. In
    combination with the respective depthcharge patch, this will switch to
    Thumb mode right after the entry point of the bootblock and not switch
    back to ARM until the final assembly stub that jumps to the kernel.
    
    The required changes to make this work include some new headers and
    Makefile flags to handle assembly files (using the unified syntax and
    the same helper macros as Linux), modifying our custom-written libgcc
    code for 64-bit division to support Thumb (removing some stale old files
    that were never really used for clarity), and flipping the general
    CFLAGS to Thumb (some more cleanup there as well while I'm at it).
    
    BUG=None
    TEST=Snow and Nyan still boot.
    
    Original-Change-Id: I80c04281e3adbf74f9f477486a96b9fafeb455b3
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/182212
    Original-Reviewed-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit 5f65c17cbfae165a95354146ae79e06c512c2c5a)
    
    Conflicts:
    	payloads/libpayload/include/arm/arch/asm.h
    	src/arch/arm/Makefile.inc
    	src/arch/arm/armv7/Makefile.inc
    
    *** There is an issue with what to do with ramstage-S-ccopts, and
    *** will need to be covered in additional ARM cleanup patches.
    
    Change-Id: I80c04281e3adbf74f9f477486a96b9fafeb455b3
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    Reviewed-on: http://review.coreboot.org/6930
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/6930 for details.

-gerrit



More information about the coreboot-gerrit mailing list