[coreboot-gerrit] New patch to review for coreboot: 89d5c74 inteltool: Fix message in case of multiple LPC controllers

[Mathias Krause (minipli@googlemail.com)]

Mathias Krause (minipli at googlemail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7342

-gerrit

commit 89d5c74e6c9b652a763f95e8e955be8d0430bc96
Author: Mathias Krause <minipli at googlemail.com>
Date:   Wed Nov 5 21:27:01 2014 +0100

    inteltool: Fix message in case of multiple LPC controllers
    
    If we find multiple LPC controllers, we want to tell the user that we'll
    ignore all but the first. However, we use 'dev' in the message (the
    current device found) instead of 'sb' (the one we want to use).
    
    Fix the message by using 'sb' and break the loop right away in this
    case. It's sufficient to tell the user once which LPC controller we'll
    use.
    
    Change-Id: Ibd27e40525fabe8c63b112691ad49fd994c70a48
    Signed-off-by: Mathias Krause <minipli at googlemail.com>
---
 util/inteltool/inteltool.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index 5e320e2..9775aeb 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -338,13 +338,14 @@ int main(int argc, char *argv[])
 		pci_fill_info(dev, PCI_FILL_CLASS);
 		/* The ISA/LPC bridge can be 0x1f, 0x07, or 0x04 so we probe. */
 		if (dev->device_class == 0x0601) { /* ISA/LPC bridge */
-			if (sb == NULL)
+			if (sb == NULL) {
 				sb = dev;
-			else
+			} else {
 				fprintf(stderr, "Multiple devices with class ID"
 					" 0x0601, using %02x%02x:%02x.%02x\n",
-					dev->domain, dev->bus, dev->dev,
-					dev->func);
+					sb->domain, sb->bus, sb->dev, sb->func);
+				break;
+			}
 		}
 	}