[coreboot-gerrit] Patch merged into coreboot/master: 169c0df ARM: Use local versions of libgcc functions instead of linking against libgcc.

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 5 01:49:11 CET 2014


the following patch was just integrated into master:
commit 169c0df6b8f07268e3bc49f35520df692705f5d8
Author: Gabe Black <gabeblack at google.com>
Date:   Tue Oct 8 18:24:10 2013 -0700

    ARM: Use local versions of libgcc functions instead of linking against libgcc.
    
    The flags used to compile libgcc may make it incompatible with the code it's
    linked against, and/or the hardware it's going to run on. Rather than try to
    tease the right libgcc from the compiler, lets just leave it out and use our
    own implementations of the necessary functions.
    
    Most of these implementations were taken from the Linux kernel, except for
    uldivmod.S which was taken from a CL originally written for U-Boot by
    Che-Liang Chiou in December of 2010. It was modified to not use the CLZ
    instruction on machines that don't have it, anything earlier than ARMv5. The
    top block was taken from an earlier version of the same CL which didn't use
    CLZ in that spot. The later block was written from scratch.
    
    BUG=None
    TEST=Built and booted into the bootblock on nyan. Ran a series of tests which
    divided and modded a 64 bit value by various 32 bit values which were powers
    of 2. Confirmed that this function was used and that the returned value was
    correct. Printed decimal and hex versions of some values and verified that
    they equaled each other. Built and booted on pit with serial enabled.
    BRANCH=None
    
    Original-Change-Id: I7527e28af411b7aa7f94579be95a6b352a91a224
    Original-Signed-off-by: Gabe Black <gabeblack at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/172401
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Original-Tested-by: Gabe Black <gabeblack at chromium.org>
    (cherry picked from commit be8c7a8f3292a7d7651b7c6dafc9a2c53afbd402)
    
    *** This second patch is cherry-picked and squashed again to
    *** pick up the libgcc changes that were skipped previously.
    
    arm: Move libgcc assembly macros to arch/asm.h
    
    libgcc/macros.h contains some useful assembly macros that are common in
    Linux kernel code and facilitate things such as unified ARM/THUMB
    assembly. This patch moves it to a more general place where it can be
    used by other code as well.
    
    BUG=None
    TEST=Snow still boots.
    
    Original-Change-Id: If68e8930aaafa706c54cf9a156fac826b31bb193
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/182178
    Original-Reviewed-by: Vincent Palatin <vpalatin at chromium.org>
    (cherry picked from commit a780670def94a969829811fa8cf257f12b88f085)
    
    *** Additional changes for stage specific builds
    
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    Change-Id: Ie3e48f34ebf6fbe20c3dd76ecbcbea7844e9466e
    Reviewed-on: http://review.coreboot.org/7322
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/7322 for details.

-gerrit



More information about the coreboot-gerrit mailing list