[coreboot-gerrit] Patch set updated for coreboot: 06880f6 Intel: Add common header file for CAR setup

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Mon May 26 12:57:51 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5872

-gerrit

commit 06880f655609f2980450e6a8580e02c1971cee0c
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Mon May 26 17:38:23 2014 +1000

    Intel: Add common header file for CAR setup
    
    When passing '-ffreestanding' the 'main' romstage.c may no longer
    necessarily be considered the entry point.
    
    From the C specification in 5.1.2.1 Freestanding environment;
    
    "In a freestanding environment (in which C program execution may take
    place without any benefit of an operating system), the name and type of
    the function called at program startup are implementation-defined."
    
    Clang complains about these being missing as Clang is somewhat more
    strict about the spec than GNU/GCC is. An advantage here is that a
    different entry-point type-signature shall now be warned about at
    compile time.
    
    Change-Id: I467001adabd47958c30c9a15e3248e42ed1151f3
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/include/cpu/intel/car.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/include/cpu/intel/car.h b/src/include/cpu/intel/car.h
new file mode 100644
index 0000000..dc89ffc
--- /dev/null
+++ b/src/include/cpu/intel/car.h
@@ -0,0 +1,7 @@
+#ifndef _CPU_INTEL_CAR_H
+#define _CPU_INTEL_CAR_H
+
+/* std signature of entry-point to romstage.c */
+void main(unsigned long bist);
+
+#endif /* _CPU_INTEL_CAR_H */



More information about the coreboot-gerrit mailing list