[coreboot-gerrit] New patch to review for coreboot: e99fe23 ite/common: Introduce common watchdog and 3.3V VSB helpers

Rudolf Marek (r.marek@assembler.cz) gerrit at coreboot.org
Tue May 13 17:18:04 CEST 2014


Rudolf Marek (r.marek at assembler.cz) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5728

-gerrit

commit e99fe230abf47f0b9d847ad4d779f29c3b2ad20d
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Tue May 13 15:57:47 2014 +0200

    ite/common: Introduce common watchdog and 3.3V VSB helpers
    
    Introduce the watchog and 3.3 VSB helper functions.
    The IT8712F can be migrated to use those too. To be used
    with IT8728F.
    
    Change-Id: If21e99b6069c7222f0bc8eb7c7121fe119b8dfe1
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
---
 src/superio/ite/common/early_serial.c | 40 +++++++++++++++++++++++++++++++++++
 src/superio/ite/common/ite.h          |  2 ++
 2 files changed, 42 insertions(+)

diff --git a/src/superio/ite/common/early_serial.c b/src/superio/ite/common/early_serial.c
index 35fb59d..73354d4 100644
--- a/src/superio/ite/common/early_serial.c
+++ b/src/superio/ite/common/early_serial.c
@@ -29,6 +29,8 @@
 #define ITE_CONFIG_REG_LDN       0x07 /* Logical Device Number. */
 #define ITE_CONFIG_REG_CLOCKSEL  0x23 /* Clock Selection. */
 #define ITE_CONFIG_REG_SWSUSP    0x24 /* Software Suspend, Flash I/F. */
+#define ITE_CONFIG_REG_MFC       0x2a /* multi function pin */
+#define ITE_CONFIG_REG_WATCHDOG  0x72 /* watchdog config */
 
 /* Helper procedure */
 static void ite_sio_write(device_t dev, u8 reg, u8 value)
@@ -84,3 +86,41 @@ void ite_enable_serial(device_t dev, u16 iobase)
 	pnp_set_enable(dev, 1);
 	pnp_exit_conf_state(dev);
 }
+
+/*
+ *
+ * LDN 7, reg 0x2a - needed for S3, or memory power will be cut off
+ * this was documented only in IT8712F_V0.9.2!
+ *
+ * Enable 3VSBSW#. (For System Suspend-to-RAM)
+ * 0: 3VSBSW# will be always inactive.
+ * 1: 3VSBSW# enabled. It will be (NOT SUSB#) NAND SUSC#.
+ *
+ * in romstage.c
+ * #define GPIO_DEV PNP_DEV(0x2e, ITE_GPIO)
+ * and pass: GPIO_DEV
+ */
+
+void ite_enable_3vsbsw(device_t dev)
+{
+	u8 tmp;
+	pnp_enter_conf_state(dev);
+	pnp_set_logical_device(dev);
+	tmp = pnp_read_config(dev, ITE_CONFIG_REG_MFC);
+	tmp |= 0x80;
+	pnp_write_config(dev, ITE_CONFIG_REG_MFC, tmp);
+	pnp_exit_conf_state(dev);
+}
+
+/*
+ * in romstage.c
+ * #define GPIO_DEV PNP_DEV(0x2e, ITE_GPIO)
+ * and pass: GPIO_DEV
+*/
+
+void ite_kill_watchdog(device_t dev)
+{
+	pnp_enter_conf_state(dev);
+	ite_sio_write(dev, ITE_CONFIG_REG_WATCHDOG, 0x00);
+	pnp_exit_conf_state(dev);
+}
diff --git a/src/superio/ite/common/ite.h b/src/superio/ite/common/ite.h
index f21381d..5389f14 100644
--- a/src/superio/ite/common/ite.h
+++ b/src/superio/ite/common/ite.h
@@ -32,5 +32,7 @@ void ite_enable_serial(device_t dev, u16 iobase);
 
 /* Some boards need to init wdt+gpio's very early */
 void ite_reg_write(device_t dev, u8 reg, u8 value);
+void ite_enable_3vsbsw(device_t dev);
+void ite_kill_watchdog(device_t dev);
 
 #endif /* SUPERIO_ITE_COMMON_ROMSTAGE_H */



More information about the coreboot-gerrit mailing list