[coreboot-gerrit] Patch set updated for coreboot: f93f42b libpayload: hexdump.c: Change type of length argument to size_t

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Wed Mar 26 06:03:55 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4768

-gerrit

commit f93f42bfafc805104fd6a223a9f25dad3ef0c775
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Jan 21 14:30:51 2014 +0100

    libpayload: hexdump.c: Change type of length argument to size_t
    
    Representing a (non-negative) length with a signed integer is not
    optimal, so change its type to `size_t`.
    
    Change-Id: Ic0c2b7e081ba32d917409568ee53007d9ab7f8f3
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 payloads/libpayload/include/libpayload.h | 2 +-
 payloads/libpayload/libc/hexdump.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index 10a4505..8a0d915 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -294,7 +294,7 @@ long int labs(long int j);
 long long int llabs(long long int j);
 u8 bin2hex(u8 b);
 u8 hex2bin(u8 h);
-void hexdump(void *memory, int length);
+void hexdump(void *memory, size_t length);
 void fatal(const char *msg) __attribute__ ((noreturn));
 /** @} */
 
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index 814adf2..e33a306 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -29,7 +29,7 @@
 
 #include <libpayload.h>
 
-void hexdump(void *memory, int length)
+void hexdump(void *memory, size_t length)
 {
 	int i;
 	uint8_t *m;



More information about the coreboot-gerrit mailing list