[coreboot-gerrit] Patch set updated for coreboot: 47ba1a7 util/cbfstool: Fix double free crash.
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Sat Mar 8 14:39:52 CET 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5353
-gerrit
commit 47ba1a7220023bd3465c2c6c20146b6fc6ba51a1
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Sun Mar 9 00:05:18 2014 +1100
util/cbfstool: Fix double free crash.
To reproduce the crash pass the following arguments where the files
passed, in fact, do not exist. As follows:
./cbfstool build/coreboot.rom extract -n config -f /tmp/config.txt
Change-Id: I2213ff175d0703705a0ec10271b30bb26b6f8d0a
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
util/cbfstool/cbfstool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 792dd91..c33ce95 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -474,7 +474,7 @@ static int cbfs_extract(void)
if (cbfs_image_from_file(&image, param.cbfs_name) != 0) {
ERROR("Could not load ROM image '%s'.\n",
param.cbfs_name);
- result = 1;
+ return 1;
} else if (cbfs_export_entry(&image, param.name,
param.filename) != 0) {
result = 1;
More information about the coreboot-gerrit
mailing list