[coreboot-gerrit] New patch to review for coreboot: 66b90a1 lib/dynamic_cbmem.c: Add prototype for `cbmemc_reinit()`
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sat Mar 8 11:44:23 CET 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5351
-gerrit
commit 66b90a1d136f3741f38897d0f525de4e1e1c80a2
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sat Mar 8 11:37:46 2014 +0100
lib/dynamic_cbmem.c: Add prototype for `cbmemc_reinit()`
Enabling CBMEM console for boards using dynamic CBMEM,
board.i386/google/bolt
board.i386/google/falco
board.i386/google/peppy
board.ARMV7/google/pit
board.i386/google/rambi
board.i386/google/slippy
board.ARMV7/google/snow
board.i386/intel/baskingridge
board.i386/intel/cougar_canyon2
board.i386/intel/wtm2
the build fails with the error below.
CC lib/dynamic_cbmem.ramstage.o
src/lib/dynamic_cbmem.c: In function 'init_cbmem_pre_device':
src/lib/dynamic_cbmem.c:425:2: error: implicit declaration of function 'cbmemc_reinit' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make: *** [coreboot-builds/google_bolt/lib/dynamic_cbmem.ramstage.o] Error 1
Including the header file `cbmem_console.h` with the prototype for
`cbmemc_reinit()` fixes this error.
Change-Id: If41f9e08df98d79b7bbf740b1a5634d0140207be
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/lib/dynamic_cbmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/lib/dynamic_cbmem.c b/src/lib/dynamic_cbmem.c
index 322ead0..1382f1d 100644
--- a/src/lib/dynamic_cbmem.c
+++ b/src/lib/dynamic_cbmem.c
@@ -21,6 +21,7 @@
#include <bootmem.h>
#include <console/console.h>
#include <cbmem.h>
+#include <console/cbmem_console.h>
#include <string.h>
#include <stdlib.h>
#include <arch/early_variables.h>
More information about the coreboot-gerrit
mailing list