[coreboot-gerrit] Patch set updated for coreboot: 41dead2 baytrail: allow function disable on TXE

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Mar 4 16:36:57 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4925

-gerrit

commit 41dead2a123f6700a55dfcc1141769855c4e35c9
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Oct 30 17:08:59 2013 -0500

    baytrail: allow function disable on TXE
    
    Previously it was not known how to put the TXE pci device
    into D3Hot. It's been disseminated that this is not a requirement
    for disabling the TXE pci device in the function disable register.
    Therefore, allow this by returning 0 from place_device_in_d3hot().
    
    BUG=chrome-os-partner:22871
    BRANCH=None
    TEST=Temporarily set TXE to be disabled. Noted FUNC_DIS was being
         set accordingly.
    
    Change-Id: Ibf537bf8ba718859591dc89bdf41e57c1ea9d836
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/175490
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/baytrail/southcluster.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c
index eacabf3..42349fa 100644
--- a/src/soc/intel/baytrail/southcluster.c
+++ b/src/soc/intel/baytrail/southcluster.c
@@ -322,7 +322,8 @@ static int place_device_in_d3hot(device_t dev)
 		offset = 0x50;
 		break;
 	case PCI_DEVFN(TXE_DEV, TXE_FUNC):
-		break;
+		/* TXE cannot be placed in D3Hot. */
+		return 0;
 	case PCI_DEVFN(PCIE_PORT1_DEV, PCIE_PORT1_FUNC):
 		offset = 0xa0;
 		break;



More information about the coreboot-gerrit mailing list