[coreboot-gerrit] New patch to review for coreboot: 3b3d6cc sb/amd/amd8111/acpi.c: Remove set but unused variable `dword`
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sat Mar 1 13:12:18 CET 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5315
-gerrit
commit 3b3d6cc996131d8fc7a4c78703e96b8e55a7e376
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sat Mar 1 12:49:57 2014 +0100
sb/amd/amd8111/acpi.c: Remove set but unused variable `dword`
Removing `-Wno-unused-but-set-variable` from `CFLAGS` results in the error
below, when building for example the HP DL145 GL1.
CC southbridge/amd/amd8111/acpi.ramstage.o
src/southbridge/amd/amd8111/acpi.c: In function 'acpi_init':
src/southbridge/amd/amd8111/acpi.c:100:11: error: variable 'dword' set but not used [-Werror=unused-but-set-variable]
Removing the variable `dword` fixes this error.
The read is left in the code, as I do not know if it has an effect or
not.
Change-Id: I9957cef3a996c5974c275423c9de63ccf230974e
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/southbridge/amd/amd8111/acpi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/southbridge/amd/amd8111/acpi.c b/src/southbridge/amd/amd8111/acpi.c
index b734846..bfa5224 100644
--- a/src/southbridge/amd/amd8111/acpi.c
+++ b/src/southbridge/amd/amd8111/acpi.c
@@ -97,7 +97,6 @@ static void acpi_init(struct device *dev)
{
uint8_t byte;
uint16_t pm10_bar;
- uint32_t dword;
int on;
#if 0
@@ -156,7 +155,7 @@ static void acpi_init(struct device *dev)
if(on) {
pm10_bar = (pci_read_config16(dev, 0x58)&0xff00);
outl(((on<<1)+0x10) ,(pm10_bar + 0x10));
- dword = inl(pm10_bar + 0x10);
+ inl(pm10_bar + 0x10);
on = 8-on;
printk(BIOS_DEBUG, "Throttling CPU %2d.%1.1d percent.\n",
(on*12)+(on>>1),(on&1)*5);
More information about the coreboot-gerrit
mailing list