[coreboot-gerrit] New patch to review for coreboot: 544d1c1 x86 MTRR: Drop unused return value
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Mon Jun 30 12:54:53 CEST 2014
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6166
-gerrit
commit 544d1c1b6315e350ddf21601f51674926e6c95b5
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Mon Jun 30 13:48:18 2014 +0300
x86 MTRR: Drop unused return value
It was never well-defined what value this function should return.
Change-Id: If84aff86e0b556591d7ad557842910a2dfcd3b46
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/cpu/x86/mtrr/mtrr.c | 3 +--
src/include/cpu/x86/mtrr.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index 8826535..b19b853 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -772,7 +772,7 @@ void x86_setup_mtrrs(void)
x86_setup_var_mtrrs(address_size, 1);
}
-int x86_mtrr_check(void)
+void x86_mtrr_check(void)
{
/* Only Pentium Pro and later have MTRR */
msr_t msr;
@@ -795,5 +795,4 @@ int x86_mtrr_check(void)
printk(BIOS_DEBUG, "\n");
post_code(0x93);
- return ((int) msr.lo);
}
diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h
index 2a44072..95cabf1 100644
--- a/src/include/cpu/x86/mtrr.h
+++ b/src/include/cpu/x86/mtrr.h
@@ -66,7 +66,7 @@ void enable_fixed_mtrr(void);
void x86_setup_fixed_mtrrs(void);
/* Set up fixed MTRRs but do not enable them. */
void x86_setup_fixed_mtrrs_no_enable(void);
-int x86_mtrr_check(void);
+void x86_mtrr_check(void);
#endif
#if !defined(__ASSEMBLER__) && defined(__PRE_RAM__) && !defined(__ROMCC__)
More information about the coreboot-gerrit
mailing list