[coreboot-gerrit] Patch set updated for coreboot: abb2d0b cpu/x86/pae/pgtbl.c: Unsigned comparison < 0 always false

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Sat Jun 28 12:58:06 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6146

-gerrit

commit abb2d0b75dbee3b89ce7fa015cf18c10c055d46e
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Sat Jun 28 15:33:30 2014 +1000

    cpu/x86/pae/pgtbl.c: Unsigned comparison < 0 always false
    
    Comparison of unsigned expression < 0 is always false.
    
    Change-Id: Idf4e7846b50f4376a5d33515681efbd773d1caca
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/cpu/x86/pae/pgtbl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/x86/pae/pgtbl.c b/src/cpu/x86/pae/pgtbl.c
index 9354738..9be415d 100644
--- a/src/cpu/x86/pae/pgtbl.c
+++ b/src/cpu/x86/pae/pgtbl.c
@@ -61,7 +61,7 @@ void *map_2M_page(unsigned long page)
 	void *result;
 	int i;
 	index = cpu_index();
-	if ((index < 0) || (index >= CONFIG_MAX_CPUS)) {
+	if (index >= CONFIG_MAX_CPUS) {
 		return MAPPING_ERROR;
 	}
 	window = page >> 10;



More information about the coreboot-gerrit mailing list