[coreboot-gerrit] New patch to review for coreboot: 33a55a7 Makefile.inc: Detect if a working clang binary exists before set
Edward O'Callaghan (eocallaghan@alterapraxis.com)
gerrit at coreboot.org
Fri Jun 27 10:36:46 CEST 2014
Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6141
-gerrit
commit 33a55a74588fbc3f08a197cdd3bbe2c72dc49744
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date: Fri Jun 27 18:22:53 2014 +1000
Makefile.inc: Detect if a working clang binary exists before set
Let us not assume the 'clang' binary exists and is working just because
the user selected it in .config
Change-Id: Iad3cbf4a7cda0e1c4d435fbe426b7247233973ea
Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index b9a3fe9..7ac9c22 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -30,7 +30,7 @@ ifneq ($(NOCOMPILE),1)
ifneq ($(CONFIG_ANY_TOOLCHAIN),y)
_toolchain=$(shell $(CC_x86_32) -v 2>&1 |grep -q "gcc version .*coreboot toolchain" && echo coreboot)
ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
-_toolchain=coreboot
+_toolchain=$(shell $(CC_x86_32) -v 2>&1 |grep -q "clang version" && echo coreboot)
endif
ifneq ($(_toolchain),coreboot)
$(error Please use the coreboot toolchain (or prove that your toolchain works))
More information about the coreboot-gerrit
mailing list