[coreboot-gerrit] New patch to review for coreboot: 8e5d771 northbridge/intel/nehalem/raminit.c: Stray '; ' at the end of while

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jun 26 14:22:25 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6129

-gerrit

commit 8e5d7717702a73c8d2a9c74afd76e5b2e54ec044
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jun 26 22:20:05 2014 +1000

    northbridge/intel/nehalem/raminit.c: Stray ';' at the end of while
    
    NOTFORMERGE: RFC!
    
    Spotted by Clang.
    
    Change-Id: Ic7f63830e9ea61ba2f2965225e70ab8a4f227a66
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/intel/nehalem/raminit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c
index 1bf5fcd..39c6346 100644
--- a/src/northbridge/intel/nehalem/raminit.c
+++ b/src/northbridge/intel/nehalem/raminit.c
@@ -4574,8 +4574,7 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
 	write_mchbar32(0x140, read_mchbar32(0x140) & ~0x07000000);
 	write_mchbar32(0x138, read_mchbar32(0x138) & ~0x07000000);
 	write_mchbar32(0x130, 0x31111301);
-	while (read_mchbar32(0x130) & 1) ;
-
+	while (read_mchbar32(0x130) & 1)
 	{
 		u32 t;
 		u8 val_a1;



More information about the coreboot-gerrit mailing list