[coreboot-gerrit] New patch to review for coreboot: 62b7cb1 northbridge/intel/nehalem/raminit.c: Extraneous parenthese

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jun 26 14:22:21 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6124

-gerrit

commit 62b7cb15f19fa4e8573575697ca9b4cfaf66797b
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jun 26 21:38:52 2014 +1000

    northbridge/intel/nehalem/raminit.c: Extraneous parenthese
    
    Equality comparison with extraneous parenthese, spotted by Clang.
    
    Change-Id: I8d532392a0365753583ed441958e06d5da784587
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/intel/nehalem/raminit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c
index a2960f6..2ddc35c 100644
--- a/src/northbridge/intel/nehalem/raminit.c
+++ b/src/northbridge/intel/nehalem/raminit.c
@@ -4148,7 +4148,7 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
 	write_mchbar32(0x1af0, 0x1f020003);
 	gav(read_mchbar32(0x1af0));	// !!!!
 
-	if (((x2ca8 == 0))) {
+	if (x2ca8 == 0) {
 		write_mchbar8(0x2ca8, read_mchbar8(0x2ca8) | 1);	// guess
 	}
 



More information about the coreboot-gerrit mailing list