[coreboot-gerrit] New patch to review for coreboot: 29d7f1b Use MTRR defines

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jun 26 11:16:24 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6123

-gerrit

commit 29d7f1b4007089c798454e3e7644e48eaa0870ff
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Jun 25 01:22:17 2014 +0300

    Use MTRR defines
    
    Change-Id: I60ae6dcb8c3b280fe74f27f4d61de70cc1ba190b
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/x86/mtrr/mtrr.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index 86e31d0..8826535 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -778,17 +778,16 @@ int x86_mtrr_check(void)
 	msr_t msr;
 	printk(BIOS_DEBUG, "\nMTRR check\n");
 
-	msr = rdmsr(0x2ff);
-	msr.lo >>= 10;
+	msr = rdmsr(MTRRdefType_MSR);
 
 	printk(BIOS_DEBUG, "Fixed MTRRs   : ");
-	if (msr.lo & 0x01)
+	if (msr.lo & MTRRdefTypeFixEn)
 		printk(BIOS_DEBUG, "Enabled\n");
 	else
 		printk(BIOS_DEBUG, "Disabled\n");
 
 	printk(BIOS_DEBUG, "Variable MTRRs: ");
-	if (msr.lo & 0x02)
+	if (msr.lo & MTRRdefTypeEn)
 		printk(BIOS_DEBUG, "Enabled\n");
 	else
 		printk(BIOS_DEBUG, "Disabled\n");



More information about the coreboot-gerrit mailing list