[coreboot-gerrit] New patch to review for coreboot: b132573 arch/x86/include/bootblock_common.h: Sanitize header inclusion

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Thu Jun 26 10:19:51 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6119

-gerrit

commit b132573b6aa2242c5669c5070e0193dd3bc3015d
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jun 26 18:09:34 2014 +1000

    arch/x86/include/bootblock_common.h: Sanitize header inclusion
    
    Sanitize the inclusion of mc146818rtc.h in bootblock_common.h
    
    Change-Id: I37d9ffd1375aedbf1f3eaa4ddce27e16166ce0b9
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/arch/x86/include/bootblock_common.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/arch/x86/include/bootblock_common.h b/src/arch/x86/include/bootblock_common.h
index 4926086..276b514 100644
--- a/src/arch/x86/include/bootblock_common.h
+++ b/src/arch/x86/include/bootblock_common.h
@@ -1,5 +1,6 @@
-#include <cpu/x86/lapic/boot_cpu.c>
 #include <arch/cbfs.h>
+#include <cpu/x86/lapic/boot_cpu.c>
+#include <pc80/mc146818rtc.h>
 
 #ifdef CONFIG_BOOTBLOCK_CPU_INIT
 #include CONFIG_BOOTBLOCK_CPU_INIT
@@ -29,8 +30,6 @@ static void bootblock_mainboard_init(void)
 #endif
 
 #if CONFIG_USE_OPTION_TABLE
-#include <pc80/mc146818rtc.h>
-
 static void sanitize_cmos(void)
 {
 	if (cmos_error() || !cmos_chksum_valid()) {
@@ -48,8 +47,6 @@ static void sanitize_cmos(void)
 #endif
 
 #if CONFIG_CMOS_POST
-#include <pc80/mc146818rtc.h>
-
 static void cmos_post_init(void)
 {
 	u8 magic = CMOS_POST_BANK_0_MAGIC;



More information about the coreboot-gerrit mailing list