[coreboot-gerrit] New patch to review for coreboot: d49220a drivers/intel/gma: Equality comparison with extraneous parentheses

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Jun 17 07:19:04 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6053

-gerrit

commit d49220ac4b19e44be24a458a752f8183102d02ea
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Tue Jun 17 15:09:51 2014 +1000

    drivers/intel/gma: Equality comparison with extraneous parentheses
    
    Spotted by Clang.
    
    Change-Id: I3e612c0fa050a09fa7e5b1cb643935b84eb2b957
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/drivers/intel/gma/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/intel/gma/intel_dp.c b/src/drivers/intel/gma/intel_dp.c
index b824cb7..30c2568 100644
--- a/src/drivers/intel/gma/intel_dp.c
+++ b/src/drivers/intel/gma/intel_dp.c
@@ -811,7 +811,7 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)
 	ironlake_wait_panel_power_cycle(intel_dp);
 
 	pp = ironlake_get_pp_control();
-	if ((intel_dp->gen == 5)) {
+	if (intel_dp->gen == 5) {
 		/* ILK workaround: disable reset around power sequence */
 		pp &= ~PANEL_POWER_RESET;
 		io_i915_write32(pp, PCH_PP_CONTROL);
@@ -827,7 +827,7 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)
 
 	ironlake_wait_panel_on(intel_dp);
 
-	if ((intel_dp->gen == 5)) {
+	if (intel_dp->gen == 5) {
 		pp |= PANEL_POWER_RESET; /* restore panel reset bit */
 		io_i915_write32(pp, PCH_PP_CONTROL);
 		////POSTING_READ(PCH_PP_CONTROL);



More information about the coreboot-gerrit mailing list