[coreboot-gerrit] Patch set updated for coreboot: 3639d78 lenovo/x60/i915.c: Add comment about `FRAME_BUFFER_PAGES` in `set_gtt()`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Jun 9 00:05:28 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5938

-gerrit

commit 3639d78694c9a32c5c065cda7b44381f884da36a
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Jun 5 21:36:18 2014 +0200

    lenovo/x60/i915.c: Add comment about `FRAME_BUFFER_PAGES` in `set_gtt()`
    
    The define FRAME_BUFFER_PAGES = (1024 * 768)/1024 should be exactly
    the amount of needed pages. But using that value causes corruptions
    of the GRUB menu screen.
    
    Change-Id: Ifae2a50080b0fbcdd0d3489c8da1535cbbb05eef
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/lenovo/x60/i915.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c
index 328b0cb..af7a789 100644
--- a/src/mainboard/lenovo/x60/i915.c
+++ b/src/mainboard/lenovo/x60/i915.c
@@ -352,6 +352,7 @@ int i915lightup(unsigned int pphysbase, unsigned int piobase,
 		return 0;
 	}
 
+	/* Why does FRAME_BUFFER_PAGES = 768 cause corruptions in GRUB? */
 	setgtt(0, 800, physbase, 4096);
 
 	temp = READ32(PGETBL_CTL);



More information about the coreboot-gerrit mailing list