[coreboot-gerrit] Patch set updated for coreboot: 9a7f1be device/oprom/realmode/x86.c: Fix memory leak

Daniele Forsi (dforsi@gmail.com) gerrit at coreboot.org
Sat Jul 26 12:31:12 CEST 2014


Daniele Forsi (dforsi at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6376

-gerrit

commit 9a7f1be0c2655872ac053c095d621fa9a0d7ed43
Author: Daniele Forsi <dforsi at gmail.com>
Date:   Sat Jul 26 11:32:16 2014 +0200

    device/oprom/realmode/x86.c: Fix memory leak
    
    Do not allocate memory if the bootsplash was not found.
    Found by Cppcheck 1.65. Fixes:
    [src/device/oprom/realmode/x86.c:280]: (error) Memory leak: decdata
    
    Change-Id: I8f8160d3d349c0c2b2a3ed84461729e9210153d8
    Signed-off-by: Daniele Forsi <dforsi at gmail.com>
---
 src/device/oprom/realmode/x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c
index e25c536..4338e6e 100644
--- a/src/device/oprom/realmode/x86.c
+++ b/src/device/oprom/realmode/x86.c
@@ -270,7 +270,6 @@ void vbe_set_graphics(void)
 	vbe_set_mode(&mode_info);
 #if CONFIG_BOOTSPLASH
 	struct jpeg_decdata *decdata;
-	decdata = malloc(sizeof(*decdata));
 	unsigned char *jpeg = cbfs_get_file_content(CBFS_DEFAULT_MEDIA,
 						    "bootsplash.jpg",
 						    CBFS_TYPE_BOOTSPLASH,
@@ -279,6 +278,7 @@ void vbe_set_graphics(void)
 		printk(BIOS_DEBUG, "VBE: No bootsplash found.\n");
 		return;
 	}
+	decdata = malloc(sizeof(*decdata));
 	int ret = 0;
 	ret = jpeg_decode(jpeg, framebuffer, 1024, 768, 16, decdata);
 #endif



More information about the coreboot-gerrit mailing list