[coreboot-gerrit] New patch to review for coreboot: 0a8e17c AGESA fam15: Use local bus_isa storage

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Jul 22 19:14:39 CEST 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6329

-gerrit

commit 0a8e17cb7a881b0f6f033e1387aeed2f233eb9bf
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Jul 21 18:45:14 2014 +0300

    AGESA fam15: Use local bus_isa storage
    
    Do not use a global as the value gets discarded anyway.
    
    Change-Id: I86aac304e073f0d74b011548d079e139891ec140
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/supermicro/h8qgi/mptable.c | 3 +--
 src/mainboard/supermicro/h8scm/mptable.c | 3 +--
 src/mainboard/tyan/s8226/mptable.c       | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/supermicro/h8qgi/mptable.c b/src/mainboard/supermicro/h8qgi/mptable.c
index 8b36bc7..8a248cc 100644
--- a/src/mainboard/supermicro/h8qgi/mptable.c
+++ b/src/mainboard/supermicro/h8qgi/mptable.c
@@ -32,12 +32,11 @@ extern u8 bus_sr5650[14];
 extern u8 bus_sp5100[2];
 extern u32 sbdn_sr5650;
 extern u32 sbdn_sp5100;
-extern int bus_isa;
-
 
 static void *smp_write_config_table(void *v)
 {
 	struct mp_config_table *mc;
+	int bus_isa;
 	u32 apicid_sp5100;
 	u32 apicid_sr5650;
 	device_t dev;
diff --git a/src/mainboard/supermicro/h8scm/mptable.c b/src/mainboard/supermicro/h8scm/mptable.c
index 8b36bc7..8a248cc 100644
--- a/src/mainboard/supermicro/h8scm/mptable.c
+++ b/src/mainboard/supermicro/h8scm/mptable.c
@@ -32,12 +32,11 @@ extern u8 bus_sr5650[14];
 extern u8 bus_sp5100[2];
 extern u32 sbdn_sr5650;
 extern u32 sbdn_sp5100;
-extern int bus_isa;
-
 
 static void *smp_write_config_table(void *v)
 {
 	struct mp_config_table *mc;
+	int bus_isa;
 	u32 apicid_sp5100;
 	u32 apicid_sr5650;
 	device_t dev;
diff --git a/src/mainboard/tyan/s8226/mptable.c b/src/mainboard/tyan/s8226/mptable.c
index 8b36bc7..8a248cc 100644
--- a/src/mainboard/tyan/s8226/mptable.c
+++ b/src/mainboard/tyan/s8226/mptable.c
@@ -32,12 +32,11 @@ extern u8 bus_sr5650[14];
 extern u8 bus_sp5100[2];
 extern u32 sbdn_sr5650;
 extern u32 sbdn_sp5100;
-extern int bus_isa;
-
 
 static void *smp_write_config_table(void *v)
 {
 	struct mp_config_table *mc;
+	int bus_isa;
 	u32 apicid_sp5100;
 	u32 apicid_sr5650;
 	device_t dev;



More information about the coreboot-gerrit mailing list