[coreboot-gerrit] New patch to review for coreboot: c40c876 libpayload: usb: Correct interval to 0 for endpoint0

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Tue Jul 22 17:47:34 CEST 2014


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6312

-gerrit

commit c40c876bf4b431be0954f25408e5e2bafbaf0cde
Author: Nico Huber <nico.huber at secunet.com>
Date:   Tue Jul 22 17:21:44 2014 +0200

    libpayload: usb: Correct interval to 0 for endpoint0
    
    It was accidentally set from the endpoint descriptor of endpoint1.
    Setting it to 0 shouldn't hurt, as the interval setting is never read
    for endpoint0.
    
    Change-Id: I654176c64fc18f6e5736c0fd2673cca2b04839c4
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 payloads/libpayload/drivers/usb/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c
index 47f8eb6..2d9cbe9 100644
--- a/payloads/libpayload/drivers/usb/usb.c
+++ b/payloads/libpayload/drivers/usb/usb.c
@@ -399,7 +399,7 @@ set_address (hci_t *controller, int speed, int hubport, int hubaddr)
 			dev->endpoints[0].maxpacketsize = dd->bMaxPacketSize0;
 			dev->endpoints[0].direction = SETUP;
 			dev->endpoints[0].type = CONTROL;
-			dev->endpoints[0].interval = usb_decode_interval(dev->speed, CONTROL, endp->bInterval);
+			dev->endpoints[0].interval = 0;
 			for (j = 1; j <= current->bNumEndpoints; j++) {
 #ifdef USB_DEBUG
 				static const char *transfertypes[4] = {



More information about the coreboot-gerrit mailing list