[coreboot-gerrit] New patch to review for coreboot: 7c6a96a board_status.sh minor fixes - no functional changes

[Martin Roth (gaumless@gmail.com)]

Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6261

-gerrit

commit 7c6a96acf701bb1e9f4faf3f86dfd3b4366184c7
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Thu Jul 10 15:02:19 2014 -0600

    board_status.sh minor fixes - no functional changes
    
    - Update some comments
    - Whitespace fixes
    - change from backticks to $() format for getting command data.
    
    Change-Id: Iaf424224abfd30a3581d0e43a1689cc7c887beec
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 util/board_status/board_status.sh | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index f494c89..d467362 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -24,7 +24,8 @@ NONFATAL=1
 
 # test a command
 #
-# $1: test command on remote host (0=no, 1=yes)
+# $1: 0 ($LOCAL) to run command locally,
+#     1 ($REMOTE) to run remotely if remote host defined
 # $2: command to test
 # $3: 0 ($FATAL) Exit with an error if the command fails
 #     1 ($NONFATAL) Don't exit on command test failure
@@ -37,7 +38,7 @@ test_cmd()
 	fi
 
 	if [ "$1" -eq "$REMOTE" ] && [ -n "$REMOTE_HOST" ]; then
-		ssh root@${REMOTE_HOST} which "$2" >/dev/null
+		ssh root@${REMOTE_HOST} which "$2" > /dev/null
 		rc=$?
 	else
 		which "$2" >/dev/null
@@ -79,7 +80,8 @@ _cmd()
 
 # run a command
 #
-# $1: 0 to run command locally, 1 to run remotely if remote host defined
+# $1: 0 ($LOCAL) to run command locally,
+#     1 ($REMOTE) to run remotely if remote host defined
 # $2: command
 # $3: filename to direct output of command into
 cmd()
@@ -97,7 +99,8 @@ cmd()
 
 # run a command where failure is considered to be non-fatal
 #
-# $1: 0 to run command locally, 1 to run remotely if remote host defined
+# $1: 0 ($LOCAL) to run command locally,
+#     1 ($REMOTE) to run remotely if remote host defined
 # $2: command
 # $3: filename to direct output of command into
 cmd_nonfatal()
@@ -253,7 +256,7 @@ cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
 #
 # Finish up.
 #
-coreboot_dir=`pwd`
+coreboot_dir=$(pwd)
 if [ $UPLOAD_RESULTS -eq 1 ]; then
 	# extract username from ssh://<username>@review.coreboot.org/blah
 	username=$(git config --get remote.origin.url | sed 's/ssh\:\/\///' | sed 's/@.*//')