[coreboot-gerrit] New patch to review for coreboot: b61c917 superio/fintek/f71869ad: config struct should be const qualified

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Tue Jul 8 20:15:39 CEST 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6224

-gerrit

commit b61c917a90a21708e60ab0b0dfef50cbdd84e9be
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Wed Jul 9 04:12:42 2014 +1000

    superio/fintek/f71869ad: config struct should be const qualified
    
    The 'superio_fintek_f71869ad_config' struct packed by devicetree.cb
    should have its type declared with the 'const' qualifier.
    
    Change-Id: Ieb86861ee821e77680cc4d0de202dbd7535b844d
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/superio/fintek/f71869ad/f71869ad_hwm.c       | 2 +-
 src/superio/fintek/f71869ad/f71869ad_multifunc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/superio/fintek/f71869ad/f71869ad_hwm.c b/src/superio/fintek/f71869ad/f71869ad_hwm.c
index f048299..0475081 100644
--- a/src/superio/fintek/f71869ad/f71869ad_hwm.c
+++ b/src/superio/fintek/f71869ad/f71869ad_hwm.c
@@ -64,7 +64,7 @@ static void pnp_write_index(u16 port, u8 reg, u8 value)
 /* note: multifunc registers need to be tweaked before here */
 void f71869ad_hwm_init(device_t dev)
 {
-	struct superio_fintek_f71869ad_config *conf = dev->chip_info;
+	const struct superio_fintek_f71869ad_config *conf = dev->chip_info;
 	struct resource *res = find_resource(dev, PNP_IDX_IO0);
 
 	if (!res) {
diff --git a/src/superio/fintek/f71869ad/f71869ad_multifunc.c b/src/superio/fintek/f71869ad/f71869ad_multifunc.c
index 46c4d2c..e0182ed 100644
--- a/src/superio/fintek/f71869ad/f71869ad_multifunc.c
+++ b/src/superio/fintek/f71869ad/f71869ad_multifunc.c
@@ -32,7 +32,7 @@
 
 void f71869ad_multifunc_init(device_t dev)
 {
-	struct superio_fintek_f71869ad_config *conf = dev->chip_info;
+	const struct superio_fintek_f71869ad_config *conf = dev->chip_info;
 
 	pnp_enter_conf_mode(dev);
 



More information about the coreboot-gerrit mailing list