[coreboot-gerrit] Patch set updated for coreboot: e016605 google/panther: Set default interrupt value for Environmental Controller

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Jul 6 13:04:34 CEST 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5994

-gerrit

commit e016605843264e142816020c2c4c483305bf29d5
Author: Mohammed Habibulla <moch at chromium.org>
Date:   Wed Nov 20 16:24:58 2013 -0800

    google/panther: Set default interrupt value for Environmental Controller
    
    This writes the default value to the register, but it gets rid of
    the error that disturbs some of our tests:
    
    ERROR: PNP: 002e.4 70 irq size: 0x0000000001 not assigned
    (panther port of Ieab1c776b553c996a7d06e4059110943aaf41338)
    
    BRANCH=none
    BUG=chrome-os-partner:23945
    TEST=boot test on Panther
    
    Change-Id: Id45c3bdc0d2feaf6f75d984c41d1f6ffef592d4d
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: https://chromium-review.googlesource.com/177468
    Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
    Commit-Queue: Mohammed Habibulla <moch at google.com>
    Tested-by: Mohammed Habibulla <moch at google.com>
---
 src/mainboard/google/panther/devicetree.cb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/google/panther/devicetree.cb b/src/mainboard/google/panther/devicetree.cb
index 8bce691..1966a30 100644
--- a/src/mainboard/google/panther/devicetree.cb
+++ b/src/mainboard/google/panther/devicetree.cb
@@ -110,6 +110,7 @@ chip northbridge/intel/haswell
 					device pnp 2e.4 on # Environment Controller
 						io 0x60 = 0x700
 						io 0x62 = 0x710
+						irq 0x70 = 0x09
 						irq 0xfa = 0x12
 					end
 					device pnp 2e.7 on # GPIO



More information about the coreboot-gerrit mailing list