[coreboot-gerrit] Patch set updated for coreboot: cc7ab40 chromeec: allow override of i8042 interrupt

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Thu Jan 30 05:09:24 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4978

-gerrit

commit cc7ab402f6894ee1f5306769015bd77668842e65
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Nov 20 15:18:24 2013 -0600

    chromeec: allow override of i8042 interrupt
    
    Some boards need to override which IRQ the i8042 keyboard
    controller has its interrupt on instead of the default
    IRQ#1. The SIO_EC_PS2K_IRQ macro provides the mainboard
    an ability to override the interrupt location.
    
    BUG=chrome-os-partner:23965
    BRANCH=None
    TEST=Built and booted rambi using this option. New IRQ is correctly
         picked up by kernel allowing keyboard support.
    
    Change-Id: Ic2b222018dfc3aa30e24a31009e832ae0fb7e9cf
    Reviewed-on: https://chromium-review.googlesource.com/177222
    Tested-by: Bernie Thompson <bhthompson at chromium.org>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Tested-by: Aaron Durbin <adurbin at chromium.org>
    Commit-Queue: Aaron Durbin <adurbin at chromium.org>
---
 src/ec/google/chromeec/acpi/superio.asl | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl
index 5940181..a022864 100644
--- a/src/ec/google/chromeec/acpi/superio.asl
+++ b/src/ec/google/chromeec/acpi/superio.asl
@@ -152,7 +152,11 @@ Device (SIO) {
 		{
 			IO (Decode16, 0x60, 0x60, 0x01, 0x01)
 			IO (Decode16, 0x64, 0x64, 0x01, 0x01)
+#ifdef SIO_EC_PS2K_IRQ
+			SIO_EC_PS2K_IRQ
+#else
 			IRQNoFlags () {1}
+#endif
 		})
 
 		Name (_PRS, ResourceTemplate()
@@ -160,7 +164,11 @@ Device (SIO) {
 			StartDependentFn (0, 0) {
 				IO (Decode16, 0x60, 0x60, 0x01, 0x01)
 				IO (Decode16, 0x64, 0x64, 0x01, 0x01)
+#ifdef SIO_EC_PS2K_IRQ
+				SIO_EC_PS2K_IRQ
+#else
 				IRQNoFlags () {1}
+#endif
 			}
 			EndDependentFn ()
 		})



More information about the coreboot-gerrit mailing list