[coreboot-gerrit] New patch to review for coreboot: 4c4d2b8 baytrail: first pass at lpss device initialization

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Jan 28 03:56:37 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4969

-gerrit

commit 4c4d2b825957a56600b44011afea796741191405
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Nov 12 20:21:53 2013 -0600

    baytrail: first pass at lpss device initialization
    
    This commit does the common parts for all LPSS devices
    that are enabled: enable snoop in IOSF and enable power
    management. Additionally, the i2c devices are taken out of
    reset.
    
    BUG=chrome-os-partner:23790
    BRANCH=None
    TEST=Built and booted with modified kernel-next. I2C bus devices
         show up and I see 0x10 on one of the buses.
    
    Change-Id: I540caea6a8666f5684dc5cee683a6b085dfac6de
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/176424
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/baytrail/Makefile.inc |   1 +
 src/soc/intel/baytrail/lpss.c       | 162 ++++++++++++++++++++++++++++++++++++
 2 files changed, 163 insertions(+)

diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.inc
index 240f9a1..4e3be82 100644
--- a/src/soc/intel/baytrail/Makefile.inc
+++ b/src/soc/intel/baytrail/Makefile.inc
@@ -41,6 +41,7 @@ ramstage-y += acpi.c
 ramstage-y += lpe.c
 ramstage-y += scc.c
 ramstage-y += emmc.c
+ramstage-y += lpss.c
 
 # Remove as ramstage gets fleshed out
 ramstage-y += placeholders.c
diff --git a/src/soc/intel/baytrail/lpss.c b/src/soc/intel/baytrail/lpss.c
new file mode 100644
index 0000000..ccfab38
--- /dev/null
+++ b/src/soc/intel/baytrail/lpss.c
@@ -0,0 +1,162 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2013 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <stdint.h>
+#include <arch/io.h>
+#include <console/console.h>
+#include <device/device.h>
+#include <device/pci.h>
+#include <device/pci_ids.h>
+#include <reg_script.h>
+
+#include <baytrail/iosf.h>
+#include <baytrail/pci_devs.h>
+#include <baytrail/ramstage.h>
+
+
+static void dev_enable_snoop_and_pm(device_t dev, int iosf_reg)
+{
+	struct reg_script ops[] = {
+		REG_SCRIPT_SET_DEV(dev),
+		REG_IOSF_RMW(IOSF_PORT_LPSS, iosf_reg,
+		             ~(LPSS_CTL_SNOOP | LPSS_CTL_NOSNOOP),
+		             LPSS_CTL_SNOOP | LPSS_CTL_PM_CAP_PRSNT),
+		REG_SCRIPT_END,
+	};
+
+	reg_script_run(ops);
+}
+
+static int dev_ctl_reg(device_t dev)
+{
+	int iosf_reg = -1;
+#define SET_IOSF_REG(name_) \
+	case PCI_DEVFN(name_ ## _DEV, name_ ## _FUNC): \
+		iosf_reg = LPSS_ ## name_ ## _CTL
+
+	switch (dev->path.pci.devfn) {
+	SET_IOSF_REG(SIO_DMA1);
+		break;
+	SET_IOSF_REG(I2C1);
+		break;
+	SET_IOSF_REG(I2C2);
+		break;
+	SET_IOSF_REG(I2C3);
+		break;
+	SET_IOSF_REG(I2C4);
+		break;
+	SET_IOSF_REG(I2C5);
+		break;
+	SET_IOSF_REG(I2C6);
+		break;
+	SET_IOSF_REG(I2C7);
+		break;
+	SET_IOSF_REG(SIO_DMA2);
+		break;
+	SET_IOSF_REG(PWM1);
+		break;
+	SET_IOSF_REG(PWM2);
+		break;
+	SET_IOSF_REG(HSUART1);
+		break;
+	SET_IOSF_REG(HSUART2);
+		break;
+	SET_IOSF_REG(SPI);
+		break;
+	}
+	return iosf_reg;
+}
+
+static void i2c_disable_resets(device_t dev)
+{
+	/* Release the I2C devices from reset. */
+	struct reg_script ops[] = {
+		REG_SCRIPT_SET_DEV(dev),
+		REG_RES_WRITE32(PCI_BASE_ADDRESS_0, 0x804, 0x3),
+		REG_SCRIPT_END,
+	};
+
+#define CASE_I2C(name_) \
+	case PCI_DEVFN(name_ ## _DEV, name_ ## _FUNC)
+
+	switch (dev->path.pci.devfn) {
+	CASE_I2C(I2C1):
+	CASE_I2C(I2C2):
+	CASE_I2C(I2C3):
+	CASE_I2C(I2C4):
+	CASE_I2C(I2C5):
+	CASE_I2C(I2C6):
+	CASE_I2C(I2C7):
+		printk(BIOS_DEBUG, "Releasing I2C device from reset.\n");
+		reg_script_run(ops);
+		break;
+	default:
+		return;
+	}
+}
+
+static void lpss_init(device_t dev)
+{
+	int iosf_reg = dev_ctl_reg(dev);
+
+	if (iosf_reg < 0) {
+		int slot = PCI_SLOT(dev->path.pci.devfn);
+		int func = PCI_FUNC(dev->path.pci.devfn);
+		printk(BIOS_DEBUG, "Could not find iosf_reg for %02x.%01x\n",
+		       slot, func);
+		return;
+	}
+	dev_enable_snoop_and_pm(dev, iosf_reg);
+
+	i2c_disable_resets(dev);
+}
+
+static struct device_operations device_ops = {
+	.read_resources		= pci_dev_read_resources,
+	.set_resources		= pci_dev_set_resources,
+	.enable_resources	= pci_dev_enable_resources,
+	.init			= lpss_init,
+	.enable			= NULL,
+	.scan_bus		= NULL,
+	.ops_pci		= &soc_pci_ops,
+};
+
+static const unsigned short pci_device_ids[] = {
+	SIO_DMA1_DEVID,
+	I2C1_DEVID,
+	I2C2_DEVID,
+	I2C3_DEVID,
+	I2C4_DEVID,
+	I2C5_DEVID,
+	I2C6_DEVID,
+	I2C7_DEVID,
+	SIO_DMA2_DEVID,
+	PWM1_DEVID,
+	PWM2_DEVID,
+	HSUART1_DEVID,
+	HSUART2_DEVID,
+	SPI_DEVID,
+	0,
+};
+
+static const struct pci_driver southcluster __pci_driver = {
+	.ops		= &device_ops,
+	.vendor		= PCI_VENDOR_ID_INTEL,
+	.devices	= pci_device_ids,
+};



More information about the coreboot-gerrit mailing list