[coreboot-gerrit] New patch to review for coreboot: 4f1bd3d src/console/Kconfig: Use 128 KB CBMEM console buffer for higher log levels

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat Jan 25 17:37:14 CET 2014


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4808

-gerrit

commit 4f1bd3df63b94dacde38552ca6a1cfb53e5978ad
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Jan 25 16:38:43 2014 +0100

    src/console/Kconfig: Use 128 KB CBMEM console buffer for higher log levels
    
    With console log level BIOS_SPEW and debug level set in the payload
    like SeaBIOS the CBMEM console buffer is too small and some lines
    from the payload console are lost.
    
    Therefore double the buffer size if the log level is BIOS_DEBUG or
    BIOS_SPEW.
    
    Kconfig seems to take the first `default` statement that matches, so
    the line with the if statement has to be specified first to become
    effective.
    
    Change-Id: I464fb846515c2bc17cf7eea1d138f1808489b4e6
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/console/Kconfig | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 40903c1..74067fd 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -297,10 +297,12 @@ config CONSOLE_CBMEM_BUFFER_SIZE
 	depends on CONSOLE_CBMEM
 	hex "Room allocated for console output in CBMEM"
 	default 0x10000
+	default 0x20000 if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8
 	help
-	  Space allocated for console output storage in CBMEM. The default
-	  value (64K or 0x10000 bytes) is large enough to accommodate
-	  even the BIOS_SPEW level.
+	  Space allocated for console output storage in CBMEM.
+
+	  The default value is 64K or 0x10000 bytes and for console log
+	  level BIOS_DEBUG or BIOS_SPEW it is 128K or 0x20000 bytes.
 
 config CONSOLE_CAR_BUFFER_SIZE
 	depends on CONSOLE_CBMEM



More information about the coreboot-gerrit mailing list