[coreboot-gerrit] New patch to review for coreboot: bfcb59f bachmann/ot200: Fix cmos.layout.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sat Jan 25 15:22:41 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4804

-gerrit

commit bfcb59f3bb493f88133000100a2f49915d79c5b4
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sat Jan 25 14:38:51 2014 +0100

    bachmann/ot200: Fix cmos.layout.
    
    In current cmos.layout baud_rate overlaps with hardcoded reboot byte.
    Fix the layout and provide the default for upgrade.
    
    Change-Id: I979b8743c4aab6f17b3acf61b92a74a333203379
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/bachmann/ot200/Kconfig      |  1 +
 src/mainboard/bachmann/ot200/cmos.default |  4 ++++
 src/mainboard/bachmann/ot200/cmos.layout  | 11 +++++++----
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/bachmann/ot200/Kconfig b/src/mainboard/bachmann/ot200/Kconfig
index 0bf4a70..23b206e 100644
--- a/src/mainboard/bachmann/ot200/Kconfig
+++ b/src/mainboard/bachmann/ot200/Kconfig
@@ -15,6 +15,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select PLL_MANUAL_CONFIG
 	select CORE_GLIU_500_266
 	select HAVE_OPTION_TABLE
+	select HAVE_CMOS_DEFAULT
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/bachmann/ot200/cmos.default b/src/mainboard/bachmann/ot200/cmos.default
new file mode 100644
index 0000000..05eadbf
--- /dev/null
+++ b/src/mainboard/bachmann/ot200/cmos.default
@@ -0,0 +1,4 @@
+boot_option=Fallback
+last_boot=Fallback
+baud_rate=115200
+debug_level=Spew
diff --git a/src/mainboard/bachmann/ot200/cmos.layout b/src/mainboard/bachmann/ot200/cmos.layout
index 851dff5..c60d1e9 100644
--- a/src/mainboard/bachmann/ot200/cmos.layout
+++ b/src/mainboard/bachmann/ot200/cmos.layout
@@ -24,12 +24,15 @@ entries
 # RTC reserved
 0          384       r       0        reserved_memory
 
+384          1       e       4        boot_option
+385          1       e       4        last_boot
+388          4       r       0        reboot_bits
+
 # -----------------------------------------------------------------
 # coreboot config options: console
-384          3       e       1        baud_rate
-387          4       e       2        debug_level
+392          3       e       1        baud_rate
+395          4       e       2        debug_level
 
-387          4       e       2        debug_level
 448         16       v       0        version
 
 # -----------------------------------------------------------------
@@ -59,6 +62,6 @@ enumerations
 
 checksums
 
-checksum 400 1007 1008
+checksum 392 1007 1008
 
 



More information about the coreboot-gerrit mailing list