[coreboot-gerrit] New patch to review for coreboot: 8a24006 usbdebug: Fix data toggle on receive
Kyösti Mälkki (kyosti.malkki@gmail.com)
gerrit at coreboot.org
Wed Jan 22 00:05:39 CET 2014
Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4775
-gerrit
commit 8a240062015313cb52c660384fe970021f3edb3b
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date: Tue Jan 21 10:44:08 2014 +0200
usbdebug: Fix data toggle on receive
USB device end toggles data PID when we ACK'd the zero-length data
packet. As USB host we need to toggle data PID too or the next data
received would get discarded.
Change-Id: I3203bc874c7ded9244c7548a666d7041a0fbb379
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
src/lib/usbdebug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/lib/usbdebug.c b/src/lib/usbdebug.c
index 6760aab..d0281bb 100644
--- a/src/lib/usbdebug.c
+++ b/src/lib/usbdebug.c
@@ -203,8 +203,7 @@ host_retry:
/* If I get an ACK or in-sync DATA PID, we are done. */
if ((lpid == USB_PID_ACK) || (lpid == pipe->pid)) {
- if (DBGP_LEN(rd_ctrl))
- pipe->pid ^= USB_PID_DATA_TOGGLE;
+ pipe->pid ^= USB_PID_DATA_TOGGLE;
}
/* If the port is getting full or it has dropped data
More information about the coreboot-gerrit
mailing list