[coreboot-gerrit] New patch to review for coreboot: dfdf4a2 cbfstool: correct size left calculation

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Tue Jan 21 22:29:54 CET 2014


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4772

-gerrit

commit dfdf4a292250b18c8532e86167b6434d546541f9
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Jan 21 15:28:38 2014 -0600

    cbfstool: correct size left calculation
    
    Change-Id: Iad3897dd28cf12f12ae877cfd83e1990fa7d2f0f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 util/cbfstool/cbfs_image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c
index 52727ef..f372ed9 100644
--- a/util/cbfstool/cbfs_image.c
+++ b/util/cbfstool/cbfs_image.c
@@ -380,7 +380,7 @@ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer,
 
 		DEBUG("cbfs_add_entry: space at 0x%x+0x%x(%d) bytes\n",
 		      addr, addr_next - addr, addr_next - addr);
-		if (addr + need_size > addr_next)
+		if (addr + need_size > addr_next - cbfs_calculate_file_header_size("") - sizeof(*entry))
 			continue;
 
 		// Can we simply put object here?



More information about the coreboot-gerrit mailing list