[coreboot-gerrit] New patch to review for coreboot: 1efbcf4 libpayload/libc/hexdump.c: Change type of `length` argument to `size_t`
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Tue Jan 21 14:47:59 CET 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4768
-gerrit
commit 1efbcf461633d43614a401a4a1bc49f81a2d3356
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Tue Jan 21 14:30:51 2014 +0100
libpayload/libc/hexdump.c: Change type of `length` argument to `size_t`
Representing a (non-negative) length with a signed integer is not
optimal, so change its type to `size_t`.
The same change was applied to coreboot’s implementation of `hexdump()`
in commit “lib/hexdump: Take const void * and size_t as arguments”
(3dd0e72d) [1].
[1] http://review.coreboot.org/4575
Change-Id: Ic0c2b7e081ba32d917409568ee53007d9ab7f8f3
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
payloads/libpayload/include/libpayload.h | 2 +-
payloads/libpayload/libc/hexdump.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index 10a4505..8a0d915 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -294,7 +294,7 @@ long int labs(long int j);
long long int llabs(long long int j);
u8 bin2hex(u8 b);
u8 hex2bin(u8 h);
-void hexdump(void *memory, int length);
+void hexdump(void *memory, size_t length);
void fatal(const char *msg) __attribute__ ((noreturn));
/** @} */
diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c
index 814adf2..e33a306 100644
--- a/payloads/libpayload/libc/hexdump.c
+++ b/payloads/libpayload/libc/hexdump.c
@@ -29,7 +29,7 @@
#include <libpayload.h>
-void hexdump(void *memory, int length)
+void hexdump(void *memory, size_t length)
{
int i;
uint8_t *m;
More information about the coreboot-gerrit
mailing list