[coreboot-gerrit] Patch set updated for coreboot: f3fcfaa smbios: Allow supplying other types of enclosure than "desktop".

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Jan 19 19:22:22 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4749

-gerrit

commit f3fcfaa5cffd7e069c87c9178cb9bd95e4ff2105
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Jan 19 15:30:00 2014 +0100

    smbios: Allow supplying other types of enclosure than "desktop".
    
    Default powermanagement policy is often based on this value.
    
    Change-Id: I5263e1471524d1552bb7bba9c0385c3d96c9d11f
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/x86/boot/smbios.c |  2 +-
 src/mainboard/Kconfig      | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 65bf538..8c6c881 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -230,7 +230,7 @@ static int smbios_write_type3(unsigned long *current, int handle)
 	t->bootup_state = SMBIOS_STATE_SAFE;
 	t->power_supply_state = SMBIOS_STATE_SAFE;
 	t->thermal_state = SMBIOS_STATE_SAFE;
-	t->_type = 3;
+	t->_type = CONFIG_SMBIOS_SYSTEM_ENCLOSURE_TYPE;
 	t->security_status = SMBIOS_STATE_SAFE;
 	len = t->length + smbios_string_table_len(t->eos);
 	*current += len;
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig
index d823b22..54d2941 100644
--- a/src/mainboard/Kconfig
+++ b/src/mainboard/Kconfig
@@ -335,6 +335,43 @@ config ROM_SIZE
 	default 0xc00000 if COREBOOT_ROMSIZE_KB_12288
 	default 0x1000000 if COREBOOT_ROMSIZE_KB_16384
 
+config BOARD_TYPE_DESKTOP
+	bool
+
+config BOARD_TYPE_LAPTOP
+	bool
+
+config BOARD_TYPE_SERVER
+	bool
+
+config BOARD_TYPE_HALF
+	bool
+
+config BOARD_TYPE_MINI
+	bool
+
+config BOARD_TYPE_SETTOP
+	bool
+
+config BOARD_TYPE_EMULATION
+	bool
+
+config BOARD_TYPE_SBC
+	bool
+
+config BOARD_TYPE_EVAL
+	bool
+
+config BOARD_TYPE_MISC
+	bool
+
+config SMBIOS_SYSTEM_ENCLOSURE_TYPE
+	hex
+	default 0x3 if BOARD_TYPE_DESKTOP
+	default 0xa if BOARD_TYPE_LAPTOP
+	default 0x11 if BOARD_TYPE_SERVER
+	default 0x3 if !BOARD_TYPE_DESKTOP && !BOARD_TYPE_LAPTOP && !BOARD_TYPE_SERVER
+
 config ENABLE_POWER_BUTTON
 	bool "Enable the power button" if POWER_BUTTON_IS_OPTIONAL
 	default y if POWER_BUTTON_DEFAULT_ENABLE



More information about the coreboot-gerrit mailing list