[coreboot-gerrit] New patch to review for coreboot: be996de boardstatus: Do not error out on unknown CPU/northbridge

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sun Jan 19 14:45:10 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4748

-gerrit

commit be996dee1a9667245a8bbf51c940f3186e1fd33c
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Jan 19 14:44:04 2014 +0100

    boardstatus: Do not error out on unknown CPU/northbridge
    
    On bot, stderr is unmonitored, so it make no sense to stop with an error.
    Instead use some sensible guesses.
    
    Change-Id: I6292e9fbf446b751471b95f86e7515c6680bddf3
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 util/board_status/to-wiki/towiki.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/util/board_status/to-wiki/towiki.sh b/util/board_status/to-wiki/towiki.sh
index c174527..fd0dcf0 100755
--- a/util/board_status/to-wiki/towiki.sh
+++ b/util/board_status/to-wiki/towiki.sh
@@ -317,8 +317,8 @@ EOF
 						cpu_nice="Intel® 2nd Gen (Sandybridge) Core i3/i5/i7"
 						socket_nice="Socket RPGA989";;
 					*)
-						echo "unknown northbridge $northbridge" >&2;
-						exit 1;;
+						cpu_nice="$northbridge"
+						socket_nice="$northbridge";;
 				esac
 				;;
 			INTEL_SOCKET_441)
@@ -366,13 +366,13 @@ EOF
 						cpu_nice="?"
 						socket_nice="?";;
 					*)
-						echo "unknown northbridge $northbridge ($vendor/$board)" >&2;
-						exit 1;;
+						cpu_nice="$northbridge"
+						socket_nice="$northbridge";;
 				esac
 				;;
 			*)
-				echo "unknown CPU $cpu" >&2;
-				exit 1;;
+				cpu_nice="$cpu"
+				socket_nice="$cpu";;
 		esac
 
 		echo "|- bgcolor=\"#$color\""



More information about the coreboot-gerrit mailing list