[coreboot-gerrit] Patch set updated for coreboot: b4a0556 Make version look like something thinkpad_acpi would accept

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Sat Jan 18 18:18:54 CET 2014


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4650

-gerrit

commit b4a05561e58831b2ffd0132a8209d95427d216f5
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Fri Jun 7 02:11:41 2013 +0200

    Make version look like something thinkpad_acpi would accept
    
    thinkpad_acpi checks that BIOS version matches some pattern.
    Report version in this form.
    
    Not cleaned up as the idea of this patch seems to be met with resistance.
    Can make it Thinkpad-specific if the idea is accepted.
    
    Change-Id: I15e33e87e7a7f42d6a06f12fb39b5172153af8a1
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/arch/x86/boot/smbios.c   | 7 +++++--
 src/mainboard/lenovo/Kconfig | 4 ++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 65bf538..25bdb37 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -130,12 +130,15 @@ static int smbios_write_type0(unsigned long *current, int handle)
 
 	t->vendor = smbios_add_string(t->eos, "coreboot");
 #if !CONFIG_CHROMEOS
+#ifndef CONFIG_VENDOR_VERSION
+#define CONFIG_VENDOR_VERSION ""
+#endif
 	t->bios_release_date = smbios_add_string(t->eos, COREBOOT_DMI_DATE);
 
 	if (strlen(CONFIG_LOCALVERSION))
-		t->bios_version = smbios_add_string(t->eos, CONFIG_LOCALVERSION);
+		t->bios_version = smbios_add_string(t->eos, CONFIG_VENDOR_VERSION CONFIG_LOCALVERSION);
 	else
-		t->bios_version = smbios_add_string(t->eos, COREBOOT_VERSION);
+		t->bios_version = smbios_add_string(t->eos, CONFIG_VENDOR_VERSION COREBOOT_VERSION);
 #else
 #define SPACES \
 	"                                                                  "
diff --git a/src/mainboard/lenovo/Kconfig b/src/mainboard/lenovo/Kconfig
index a29fdbf..21413fc 100644
--- a/src/mainboard/lenovo/Kconfig
+++ b/src/mainboard/lenovo/Kconfig
@@ -41,4 +41,8 @@ config MAINBOARD_VENDOR
 	string
 	default "Lenovo"
 
+config VENDOR_VERSION
+	string
+	default "CBET4000 "
+
 endif # VENDOR_LENOVO



More information about the coreboot-gerrit mailing list