[coreboot-gerrit] New patch to review for coreboot: c221023 cubieboard: Keep AHB clock within specs

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Wed Jan 8 08:23:04 CET 2014


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4629

-gerrit

commit c22102325eeef847d23909a8b9764103d536d857
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Thu Dec 26 02:02:00 2013 -0500

    cubieboard: Keep AHB clock within specs
    
    The CPU was clocked at 384MHz in the bootblock, but the AHB bus has a
    maximum rated frequency of 250MHz. Its clock needs to be divided to
    keep it within spec. Overclocking the AHB bus hung the CPU when
    memory was accessed.
    
    Change-Id: I7cb9cdd1f126b3d5b0446fc68af79b54946bc2d3
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/cubietech/cubieboard/bootblock.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/cubietech/cubieboard/bootblock.c b/src/mainboard/cubietech/cubieboard/bootblock.c
index 90dfd0d..8899160 100644
--- a/src/mainboard/cubietech/cubieboard/bootblock.c
+++ b/src/mainboard/cubietech/cubieboard/bootblock.c
@@ -15,7 +15,7 @@
 #define CPU_AHB_APB0_DEFAULT 		\
 	 CPU_CLK_SRC_OSC24M	 	\
 	 | APB0_DIV_1			\
-	 | AHB_DIV_1			\
+	 | AHB_DIV_2			\
 	 | AXI_DIV_1
 
 #define GPH_STATUS_LEDS			(1 << 20) | (1 << 21)
@@ -33,7 +33,9 @@ static void cubieboard_set_sys_clock(void)
 	/* Switch CPU clock to main oscillator */
 	write32(CPU_AHB_APB0_DEFAULT, &ccm->cpu_ahb_apb0_cfg);
 
-	/* Configure the PLL1. The value is the same one used by u-boot */
+	/* Configure the PLL1. The value is the same one used by u-boot
+	 * P = 1, N = 16, K = 1, M = 1 --> Output = 384 MHz
+	 */
 	write32(0xa1005000, &ccm->pll1_cfg);
 
 	/* FIXME: Delay to wait for PLL to lock */



More information about the coreboot-gerrit mailing list