[coreboot-gerrit] Patch merged into coreboot/master: 7176ac7 Remove CACHE_ROM.
gerrit at coreboot.org
gerrit at coreboot.org
Tue Feb 25 00:57:39 CET 2014
the following patch was just integrated into master:
commit 7176ac78e3d7ad16891b4925ce440bf2a90d0131
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Wed Feb 5 19:46:45 2014 +0100
Remove CACHE_ROM.
With the recent improvement 3d6ffe76f8a505c2dff5d5c6146da3d63dad6e82,
speedup by CACHE_ROM is reduced a lot.
On the other hand this makes coreboot run out of MTRRs depending on
system configuration, hence screwing up I/O access and cache
coherency in worst cases.
CACHE_ROM requires the user to sanity check their boot output because
the feature is brittle. The working configuration is dependent on I/O
hole size, ram size, and chipset. Because of this the current
implementation can leave a system configured in an inconsistent state
leading to unexpected results such as poor performance and/or
inconsistent cache-coherency
Remove this as a buggy feature until we figure out how to do it properly
if necessary.
Change-Id: I858d78a907bf042fcc21fdf7a2bf899e9f6b591d
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
See http://review.coreboot.org/5146 for details.
-gerrit
More information about the coreboot-gerrit
mailing list