[coreboot-gerrit] New patch to review for coreboot: 0372b68 SMM: Fixes for DEBUG_SMI

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Mon Feb 17 21:51:57 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5258

-gerrit

commit 0372b68005d2825d6736b26087f00c7777ae4fb2
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Feb 17 22:32:02 2014 +0200

    SMM: Fixes for DEBUG_SMI
    
    Get the required UART includes directly.
    The ne2k part is old copy-paste leftover.
    
    Change-Id: Ifd9253abb5a50b515887459faf06b63f907eeda9
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/x86/smm/smiutil.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/cpu/x86/smm/smiutil.c b/src/cpu/x86/smm/smiutil.c
index 13ee12e..a50a16a 100644
--- a/src/cpu/x86/smm/smiutil.c
+++ b/src/cpu/x86/smm/smiutil.c
@@ -23,6 +23,8 @@
 #include <cpu/x86/cache.h>
 #include <cpu/x86/smm.h>
 #include <console/console.h>
+#include <uart.h>
+#include <uart8250.h>
 #include <console/vtxprintf.h>
 
 #if CONFIG_CONSOLE_SERIAL8250MEM
@@ -45,9 +47,6 @@ void console_tx_byte(unsigned char byte)
 #if CONFIG_CONSOLE_SERIAL8250
 	uart8250_tx_byte(CONFIG_TTYS0_BASE, byte);
 #endif
-#if CONFIG_CONSOLE_NE2K
-	ne2k_append_data(&byte, 1, CONFIG_CONSOLE_NE2K_IO_PORT);
-#endif
 }
 
 void console_init(void)



More information about the coreboot-gerrit mailing list