[coreboot-gerrit] New patch to review for coreboot: ac5ffb7 google boards: Do not hardcode location of spd.bin

[Alexandru Gagniuc (mr.nuke.me@gmail.com)]

Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5210

-gerrit

commit ac5ffb75785135386c1b4dc52d4f6d0bdf151f49
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Feb 12 15:54:47 2014 -0600

    google boards: Do not hardcode location of spd.bin
    
    spd.bin can reside anywhere in CBFS, and we only use CBFS APIs to
    access and read it. As such, there is no need to hardcode it, and it
    can collide with mrc.bin or mrc.cache on some boards. Do not use a
    specific position for spd.bin, but instead let cbfstool find the
    optimal placement.
    
    Change-Id: I496094d3c0de708813494095b7ac4be8addb4112
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/google/bolt/Makefile.inc      | 1 -
 src/mainboard/google/falco/Makefile.inc     | 1 -
 src/mainboard/google/link/Makefile.inc      | 1 -
 src/mainboard/google/peppy/Makefile.inc     | 1 -
 src/mainboard/google/rambi/Kconfig          | 4 ----
 src/mainboard/google/rambi/spd/Makefile.inc | 1 -
 src/mainboard/google/slippy/Makefile.inc    | 1 -
 src/mainboard/samsung/lumpy/Makefile.inc    | 1 -
 8 files changed, 11 deletions(-)

diff --git a/src/mainboard/google/bolt/Makefile.inc b/src/mainboard/google/bolt/Makefile.inc
index 57f6f45..4e71be7 100644
--- a/src/mainboard/google/bolt/Makefile.inc
+++ b/src/mainboard/google/bolt/Makefile.inc
@@ -43,4 +43,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffec000
diff --git a/src/mainboard/google/falco/Makefile.inc b/src/mainboard/google/falco/Makefile.inc
index 50a47a5..3269d2d 100644
--- a/src/mainboard/google/falco/Makefile.inc
+++ b/src/mainboard/google/falco/Makefile.inc
@@ -48,4 +48,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffec000
diff --git a/src/mainboard/google/link/Makefile.inc b/src/mainboard/google/link/Makefile.inc
index 8fb69c6..ba9a5aa 100644
--- a/src/mainboard/google/link/Makefile.inc
+++ b/src/mainboard/google/link/Makefile.inc
@@ -42,4 +42,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffec000
diff --git a/src/mainboard/google/peppy/Makefile.inc b/src/mainboard/google/peppy/Makefile.inc
index 62fc6b0..7f8cae3 100644
--- a/src/mainboard/google/peppy/Makefile.inc
+++ b/src/mainboard/google/peppy/Makefile.inc
@@ -49,4 +49,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffec000
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index db6f4e2..292d321 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -32,8 +32,4 @@ config HAVE_ME_BIN
 	bool
 	default n
 
-config SPD_CBFS_ADDRESS
-	hex "Location of SPD in CBFS"
-	default 0xfffec000
-
 endif # BOARD_INTEL_BAYLEYBAY
diff --git a/src/mainboard/google/rambi/spd/Makefile.inc b/src/mainboard/google/rambi/spd/Makefile.inc
index 84695ab..36f4b66 100644
--- a/src/mainboard/google/rambi/spd/Makefile.inc
+++ b/src/mainboard/google/rambi/spd/Makefile.inc
@@ -43,4 +43,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := $(CONFIG_SPD_CBFS_ADDRESS)
diff --git a/src/mainboard/google/slippy/Makefile.inc b/src/mainboard/google/slippy/Makefile.inc
index eb2e731..7a62022 100644
--- a/src/mainboard/google/slippy/Makefile.inc
+++ b/src/mainboard/google/slippy/Makefile.inc
@@ -45,4 +45,3 @@ $(SPD_BIN): $(SPD_DEPS)
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffec000
diff --git a/src/mainboard/samsung/lumpy/Makefile.inc b/src/mainboard/samsung/lumpy/Makefile.inc
index bd47942..bb412ce 100644
--- a/src/mainboard/samsung/lumpy/Makefile.inc
+++ b/src/mainboard/samsung/lumpy/Makefile.inc
@@ -28,4 +28,3 @@ $(SPD_BIN):
 cbfs-files-y += spd.bin
 spd.bin-file := $(SPD_BIN)
 spd.bin-type := 0xab
-spd.bin-position := 0xfffdc000