[coreboot-gerrit] New patch to review for coreboot: c7e5fed haswell: Fix compile when early console is disabled

Duncan Laurie (dlaurie@google.com) gerrit at coreboot.org
Mon Feb 10 20:48:05 CET 2014


Duncan Laurie (dlaurie at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5183

-gerrit

commit c7e5fedb87470999d0f4236fd893f79cad001f2e
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Feb 10 11:43:26 2014 -0800

    haswell: Fix compile when early console is disabled
    
    The System Agent binary can be passed a pointer to the
    console transmit byte function, but if the early console
    feature is disabled then the function is not defined.
    
    Change-Id: I46b84b42491b911f832a089c094b0724ca9ebe97
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/northbridge/intel/haswell/raminit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c
index 316f7fd..15cc22f 100644
--- a/src/northbridge/intel/haswell/raminit.c
+++ b/src/northbridge/intel/haswell/raminit.c
@@ -165,8 +165,10 @@ void sdram_initialize(struct pei_data *pei_data)
 		}
 	}
 
+#if CONFIG_EARLY_CONSOLE
 	/* Pass console handler in pei_data */
 	pei_data->tx_byte = console_tx_byte;
+#endif
 
 	/* Locate and call UEFI System Agent binary. */
 	entry = (unsigned long)cbfs_get_file_content(



More information about the coreboot-gerrit mailing list