[coreboot-gerrit] New patch to review for coreboot: ea32b94 console: Drop extra uart_init()

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Wed Feb 5 16:47:21 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5140

-gerrit

commit ea32b942498c3ee7d7fb17f1a21d970bdc310279
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Feb 3 13:07:59 2014 +0200

    console: Drop extra uart_init()
    
    This call is already in console_init().
    
    Change-Id: Ie0cb3595af514e37efac5ac5d474f52ba551bf22
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/advansus/a785e-i/romstage.c     | 1 -
 src/mainboard/amd/dinar/romstage.c            | 1 -
 src/mainboard/amd/torpedo/romstage.c          | 1 -
 src/mainboard/asus/m5a88-v/romstage.c         | 1 -
 src/mainboard/avalue/eax-785e/romstage.c      | 1 -
 src/mainboard/supermicro/h8qgi/romstage.c     | 1 -
 src/mainboard/supermicro/h8scm/romstage.c     | 1 -
 src/mainboard/supermicro/x6dhr_ig2/romstage.c | 1 -
 src/mainboard/tyan/s8226/romstage.c           | 1 -
 9 files changed, 9 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/romstage.c b/src/mainboard/advansus/a785e-i/romstage.c
index c1366d5..490d146 100644
--- a/src/mainboard/advansus/a785e-i/romstage.c
+++ b/src/mainboard/advansus/a785e-i/romstage.c
@@ -102,7 +102,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	w83627hf_set_clksel_48(PNP_DEV(0x2e, 0));
 	w83627hf_enable_serial(0, CONFIG_TTYS0_BASE);
 
-	uart_init();
 	console_init();
 	printk(BIOS_DEBUG, "\n");
 
diff --git a/src/mainboard/amd/dinar/romstage.c b/src/mainboard/amd/dinar/romstage.c
index a124905..91b385f 100644
--- a/src/mainboard/amd/dinar/romstage.c
+++ b/src/mainboard/amd/dinar/romstage.c
@@ -70,7 +70,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 		}
 
 		post_code(0x31);
-		uart_init();
 		console_init();
 
 		/*
diff --git a/src/mainboard/amd/torpedo/romstage.c b/src/mainboard/amd/torpedo/romstage.c
index a2da0f0..f6204b9 100644
--- a/src/mainboard/amd/torpedo/romstage.c
+++ b/src/mainboard/amd/torpedo/romstage.c
@@ -62,7 +62,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 		kbc1100_early_init(CONFIG_SIO_PORT);
 
 		post_code(0x32);
-		uart_init();
 		post_code(0x33);
 		console_init();
 	}
diff --git a/src/mainboard/asus/m5a88-v/romstage.c b/src/mainboard/asus/m5a88-v/romstage.c
index af8e5fa..db8b7b5 100644
--- a/src/mainboard/asus/m5a88-v/romstage.c
+++ b/src/mainboard/asus/m5a88-v/romstage.c
@@ -101,7 +101,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	sb800_clk_output_48Mhz();
 
 	it8721f_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
-	uart_init();
 	console_init();
 	printk(BIOS_DEBUG, "\n");
 
diff --git a/src/mainboard/avalue/eax-785e/romstage.c b/src/mainboard/avalue/eax-785e/romstage.c
index 8d4e4b2..69cefd9 100644
--- a/src/mainboard/avalue/eax-785e/romstage.c
+++ b/src/mainboard/avalue/eax-785e/romstage.c
@@ -102,7 +102,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	w83627hf_set_clksel_48(PNP_DEV(CONFIG_SIO_PORT, 0));
 	w83627hf_enable_serial(0, CONFIG_TTYS0_BASE);
 
-	uart_init();
 	console_init();
 	printk(BIOS_DEBUG, "\n");
 
diff --git a/src/mainboard/supermicro/h8qgi/romstage.c b/src/mainboard/supermicro/h8qgi/romstage.c
index e9f359a..ea4ed8e 100644
--- a/src/mainboard/supermicro/h8qgi/romstage.c
+++ b/src/mainboard/supermicro/h8qgi/romstage.c
@@ -52,7 +52,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	sb7xx_51xx_disable_wideio(0);
 	post_code(0x34);
 
-	uart_init();
 	post_code(0x35);
 	console_init();
 
diff --git a/src/mainboard/supermicro/h8scm/romstage.c b/src/mainboard/supermicro/h8scm/romstage.c
index 61640c9..9ee1dfa 100644
--- a/src/mainboard/supermicro/h8scm/romstage.c
+++ b/src/mainboard/supermicro/h8scm/romstage.c
@@ -57,7 +57,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	sb7xx_51xx_disable_wideio(0);
 	post_code(0x34);
 
-	uart_init();
 	post_code(0x35);
 	console_init();
 
diff --git a/src/mainboard/supermicro/x6dhr_ig2/romstage.c b/src/mainboard/supermicro/x6dhr_ig2/romstage.c
index 7cfe818..4690a0c 100644
--- a/src/mainboard/supermicro/x6dhr_ig2/romstage.c
+++ b/src/mainboard/supermicro/x6dhr_ig2/romstage.c
@@ -64,7 +64,6 @@ static void main(unsigned long bist)
 
 	w83627hf_set_clksel_48(DUMMY_DEV);
 	w83627hf_enable_serial(CONSOLE_SERIAL_DEV, CONFIG_TTYS0_BASE);
-	uart_init();
 	console_init();
 
 	/* Halt if there was a built in self test failure */
diff --git a/src/mainboard/tyan/s8226/romstage.c b/src/mainboard/tyan/s8226/romstage.c
index f0b21e2..a6c33e8 100644
--- a/src/mainboard/tyan/s8226/romstage.c
+++ b/src/mainboard/tyan/s8226/romstage.c
@@ -58,7 +58,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	sb7xx_51xx_disable_wideio(0);
 	post_code(0x34);
 
-	uart_init();
 	post_code(0x35);
 	console_init();
 



More information about the coreboot-gerrit mailing list